cleanup more

Author: LoneWandererProductions

CommonLibraryTests/IoFileHandler.cs

@@ -593,7 +593,7 @@ public async Task CutListAsync()
     ///     Cuts the files valid source and target cuts files.
     /// </summary>
     [TestMethod]
-    public void CutFilesValidSourceAndTargetCutsFiles()
+    public async Task CutFilesValidSourceAndTargetCutsFilesAsync()
     {
         // Arrange
         var sourceFilePath = Path.Combine(TestSourceDir, "test.txt");
@@ -624,7 +624,7 @@ public void CutFilesSourceAndTargetEqualThrowsFileHandlerException()
     ///     Cuts the files non existent source returns false.
     /// </summary>
     [TestMethod]
-    public void CutFilesNonExistentSourceReturnsFalse()
+    public async Task CutFilesNonExistentSourceReturnsFalseAsync()
     {
         var result = FileHandleCut.CutFiles("NonExistentSource", TestTargetDir, true);
         Assert.IsFalse(result);
@@ -634,7 +634,7 @@ public void CutFilesNonExistentSourceReturnsFalse()
     ///     Cuts the files with file list cuts files successfully.
     /// </summary>
     [TestMethod]
-    public void CutFilesWithFileListCutsFilesSuccessfully()
+    public async Task CutFilesWithFileListCutsFilesSuccessfullyAsync()
     {
         // Arrange
         var sourceFilePath = Path.Combine(TestSourceDir, "test.txt");
@@ -666,7 +666,7 @@ public void CutFilesFileListNullOrEmptyThrowsFileHandlerException()
     ///     Cuts the files file list non existent file returns false.
     /// </summary>
     [TestMethod]
-    public void CutFilesFileListNonExistentFileReturnsFalse()
+    public async Task CutFilesFileListNonExistentFileReturnsFalseAsync()
     {
         var fileList = new List<string> { "NonExistentFile.txt" };
         var result = FileHandleCut.CutFiles(fileList, TestTargetDir, true);
@@ -677,7 +677,7 @@ public void CutFilesFileListNonExistentFileReturnsFalse()
     ///     Cuts the files with overwrite cuts files successfully.
     /// </summary>
     [TestMethod]
-    public void CutFilesWithOverwriteCutsFilesSuccessfully()
+    public async Task CutFilesWithOverwriteCutsFilesSuccessfullyAsync()
     {
         // Arrange
         var sourceFilePath = Path.Combine(TestSourceDir, "test.txt");
@@ -699,7 +699,7 @@ public void CutFilesWithOverwriteCutsFilesSuccessfully()
     ///     Cuts the files without overwrite existing files not overwritten.
     /// </summary>
     [TestMethod]
-    public void CutFilesWithoutOverwriteExistingFilesNotOverwritten()
+    public async Task CutFilesWithoutOverwriteExistingFilesNotOverwrittenAsync()
     {
         // Arrange
         var sourceFilePath = Path.Combine(TestSourceDir, "test.txt");
@@ -721,7 +721,7 @@ public void CutFilesWithoutOverwriteExistingFilesNotOverwritten()
     ///     Cuts the files handles subdirectories.
     /// </summary>
     [TestMethod]
-    public void CutFilesHandlesSubdirectories()
+    public async Task CutFilesHandlesSubdirectoriesAsync()
     {
         // Arrange
         var subDir = Path.Combine(TestSourceDir, "SubDir");

FileHandler/FileHandleCreate.cs

@@ -2,70 +2,68 @@
  * COPYRIGHT:   See COPYING in the top level directory
  * PROJECT:     FileHandler
  * FILE:        FileHandler/FileHandleCreate.cs
- * PURPOSE:     Does all types of File Operations, Create Files
- * PROGRAMER:   Peter Geinitz (Wayfarer)
+ * PURPOSE:     Handles all types of file creation operations
+ * PROGRAMMER:  Peter Geinitz (Wayfarer)
  */
 
-// ReSharper disable UnusedMember.Global
-
 using System;
 using System.Diagnostics;
 using System.IO;
 
 namespace FileHandler;
 
 /// <summary>
-///     The file handle create class.
+///     Handles file and folder creation.
 /// </summary>
 public static class FileHandleCreate
 {
     /// <summary>
-    ///     Create a Folder
+    ///     Creates a folder at the specified path.
     /// </summary>
-    /// <param name="path">path</param>
-    /// <exception cref="FileHandlerException">No Correct Path was provided</exception>
+    /// <param name="path">Target folder path.</param>
+    /// <exception cref="FileHandlerException">Thrown if the path is null or empty.</exception>
     public static void CreateFolder(string path)
     {
-        if (string.IsNullOrEmpty(path))
-        {
+        if (string.IsNullOrWhiteSpace(path))
             throw new FileHandlerException(FileHandlerResources.ErrorEmptyString);
-        }
 
         _ = CreateDirectory(path);
     }
 
     /// <summary>
-    ///     Creates a Folder in a specific path, based on the root folder
+    ///     Creates a folder with a specific name inside a parent path.
     /// </summary>
-    /// <param name="path">Path</param>
-    /// <param name="name">Folder Name</param>
-    /// <returns>If path was generated </returns>
-    /// <exception cref="FileHandlerException">No Correct Path was provided</exception>
+    /// <param name="path">Parent path.</param>
+    /// <param name="name">Folder name.</param>
+    /// <returns>True if the folder was created or already exists; false if creation failed.</returns>
+    /// <exception cref="FileHandlerException">Thrown if the path or name is null or empty.</exception>
     public static bool CreateFolder(string path, string name)
     {
-        if (string.IsNullOrEmpty(path) || string.IsNullOrEmpty(name))
-        {
+        if (string.IsNullOrWhiteSpace(path) || string.IsNullOrWhiteSpace(name))
             throw new FileHandlerException(FileHandlerResources.ErrorEmptyString);
-        }
 
-        var root = Path.Combine(path, name);
+        var fullPath = Path.Combine(path, name);
 
-        return CreateDirectory(root);
+        return CreateDirectory(fullPath);
     }
 
     /// <summary>
-    ///     Creates the directory.
+    ///     Creates the directory safely.
     /// </summary>
-    /// <param name="path">The path.</param>
-    /// <returns>If path was generated </returns>
+    /// <param name="path">Full folder path.</param>
+    /// <returns>True if the folder was created or already exists; false if creation failed.</returns>
     private static bool CreateDirectory(string path)
     {
         try
         {
-            _ = Directory.CreateDirectory(path);
+            // Directory.CreateDirectory is safe: it does nothing if the directory already exists.
+            Directory.CreateDirectory(path);
             return true;
         }
-        catch (Exception ex) when (ex is UnauthorizedAccessException or IOException or PathTooLongException)
+        catch (Exception ex) when (ex is UnauthorizedAccessException
+                                   or IOException
+                                   or PathTooLongException
+                                   or NotSupportedException)
         {
             FileHandlerRegister.AddError(nameof(CreateFolder), path, ex);
             Trace.WriteLine(ex);

FileHandler/FileHandlerRegister.cs

@@ -13,6 +13,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Threading;
 
 namespace FileHandler;
 
@@ -34,7 +35,7 @@ public static class FileHandlerRegister
     /// <summary>
     /// The error log lock
     /// </summary>
-    private static readonly object _errorLogLock = new();
+    private static readonly Lock _errorLogLock = new();
 
     /// <summary>
     ///     Gets the error log.