sync

Author: LoneWandererProductions

CommonControls.Converter/BooleanToVisibilityConverter.cs

@@ -57,4 +57,4 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
         public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
             => value is Visibility.Visible;
     }
-}
+}

CommonControls.Converter/ColorToNameConverter.cs

@@ -41,6 +41,7 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
 
                 return colorProperty?.Name ?? color.ToString();
             }
+
             return string.Empty;
         }
 
@@ -64,7 +65,8 @@ public object ConvertBack(object value, Type targetType, object parameter, Cultu
                 }
                 catch { return Colors.Transparent; }
             }
+
             return Colors.Transparent;
         }
     }
-}
+}

CommonControls.Converter/EnumToBooleanConverter.cs

@@ -53,4 +53,4 @@ public object ConvertBack(object value, Type targetType, object parameter, Cultu
             return Binding.DoNothing;
         }
     }
-}
+}

CommonControls.Converter/NotNullToBooleanConverter.cs

@@ -44,4 +44,4 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
         public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
             => Binding.DoNothing;
     }
-}
+}

CommonControls.Converter/NullToVisibilityConverter.cs

@@ -53,4 +53,4 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
         public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
             => Binding.DoNothing;
     }
-}
+}

CommonControls.Images/ColorPicker.xaml.cs

@@ -16,6 +16,8 @@
 using System.Windows.Media.Imaging;
 using Imaging;
 
+// ReSharper disable MemberCanBeInternal
+
 namespace CommonControls.Images
 {
     /// <inheritdoc cref="INotifyPropertyChanged" />
@@ -27,7 +29,7 @@ namespace CommonControls.Images
     /// <seealso cref="T:System.Windows.Markup.IComponentConnector" />
     public sealed partial class ColorPicker : INotifyPropertyChanged
     {
-        private WriteableBitmap _bitmap;
+        private WriteableBitmap? _bitmap;
         private bool _isDragging;
 
         // Internal state
@@ -54,7 +56,7 @@ public sealed partial class ColorPicker : INotifyPropertyChanged
         /// <summary>
         /// Occurs when [color changed].
         /// </summary>
-        public event DelegateColor ColorChanged;
+        public event DelegateColor? ColorChanged;
 
         /// <inheritdoc />
         /// <summary>
@@ -81,13 +83,15 @@ public ColorPicker()
             Alpha = alpha;
 
             // This is the trigger that will finally make it draw
-            this.SizeChanged += (s, e) =>
+            SizeChanged += (s, e) =>
             {
-                if (e.NewSize.Width > 0 && e.NewSize.Height > 0)
+                if (!(e.NewSize.Width > 0) || !(e.NewSize.Height > 0))
                 {
-                    RedrawAsync();
-                    UpdateCursors();
+                    return;
                 }
+
+                RedrawAsync();
+                UpdateCursors();
             };
         }
 
@@ -96,7 +100,7 @@ public ColorPicker()
         /// When overridden in a derived class, participates in rendering operations that are directed by the layout system. The rendering instructions for this element are not used directly when this method is invoked, and are instead preserved for later asynchronous use by layout and drawing.
         /// </summary>
         /// <param name="drawingContext">The drawing instructions for a specific element. This context is provided to the layout system.</param>
-        protected override void OnRender(System.Windows.Media.DrawingContext drawingContext)
+        protected override void OnRender(DrawingContext drawingContext)
         {
             base.OnRender(drawingContext);
             // If the bitmap hasn't been created yet, try to draw now
@@ -123,6 +127,12 @@ public bool ShowTextBoxes
 
         // --- PROPERTIES with Change Logic ---
 
+        /// <summary>
+        /// Gets or sets the hue.
+        /// </summary>
+        /// <value>
+        /// The hue.
+        /// </value>
         public double Hue
         {
             get => _h;
@@ -135,6 +145,12 @@ public double Hue
             }
         }
 
+        /// <summary>
+        /// Gets or sets the sat.
+        /// </summary>
+        /// <value>
+        /// The sat.
+        /// </value>
         public double Sat
         {
             get => _s;
@@ -147,6 +163,12 @@ public double Sat
             }
         }
 
+        /// <summary>
+        /// Gets or sets the value.
+        /// </summary>
+        /// <value>
+        /// The value.
+        /// </value>
         public double Val
         {
             get => _v;
@@ -159,6 +181,12 @@ public double Val
             }
         }
 
+        /// <summary>
+        /// Gets or sets the alpha.
+        /// </summary>
+        /// <value>
+        /// The alpha.
+        /// </value>
         public int Alpha
         {
             get => _alpha;
@@ -365,13 +393,21 @@ private void UpdateCursors()
 
         // --- RENDERING & CURSORS ---
 
+        /// <summary>
+        /// Called when [size changed].
+        /// </summary>
+        /// <param name="sender">The sender.</param>
+        /// <param name="e">The <see cref="SizeChangedEventArgs"/> instance containing the event data.</param>
         private void OnSizeChanged(object sender, SizeChangedEventArgs e)
         {
             RedrawAsync();
             UpdateCursors();
         }
 
-        // This is the "Magic" pixel drawer (Same as before)
+        /// <summary>
+        /// This is the "Magic" pixel drawer
+        /// Redraws the color picker asynchronous.
+        /// </summary>
         private void RedrawAsync()
         {
             if (!CheckAccess())
@@ -396,7 +432,7 @@ private void RedrawAsync()
             PickerContainer.Height = size;
 
             // 4. Create/Draw Bitmap (Standard)
-            if (_bitmap == null || _bitmap.PixelWidth != size || _bitmap.PixelHeight != size)
+            if (_bitmap?.PixelWidth != size || _bitmap.PixelHeight != size)
             {
                 _bitmap = new WriteableBitmap(size, size, 96, 96, PixelFormats.Bgra32, null);
                 PickerImage.Source = _bitmap;
@@ -485,6 +521,14 @@ private Point GetPointFromSv(double h, double s, double v, double r)
                 w1 * pColor.Y + w2 * pWhite.Y + w3 * pBlack.Y);
         }
 
+        /// <summary>
+        /// HSVs to int.
+        /// </summary>
+        /// <param name="h">The h.</param>
+        /// <param name="s">The s.</param>
+        /// <param name="v">The v.</param>
+        /// <param name="alpha">The alpha.</param>
+        /// <returns></returns>
         private static int HsvToInt(double h, double s, double v, int alpha)
         {
             double c = v * s;
@@ -593,8 +637,15 @@ private void GetSvFromPointClamped(double x, double y, double r, double hue, out
             v = Math.Max(0, Math.Min(1, v));
         }
 
-
-        private bool SetField<T>(ref T field, T value, [CallerMemberName] string propertyName = null)
+        /// <summary>
+        /// Sets the field.
+        /// </summary>
+        /// <typeparam name="T"></typeparam>
+        /// <param name="field">The field.</param>
+        /// <param name="value">The value.</param>
+        /// <param name="propertyName">Name of the property.</param>
+        /// <returns>Field name</returns>
+        private bool SetField<T>(ref T field, T value, [CallerMemberName] string? propertyName = null)
         {
             if (System.Collections.Generic.EqualityComparer<T>.Default.Equals(field, value)) return false;
 
@@ -603,7 +654,11 @@ private bool SetField<T>(ref T field, T value, [CallerMemberName] string propert
             return true;
         }
 
-        private void OnPropertyChanged(string propertyName) =>
+        /// <summary>
+        /// Called when [property changed].
+        /// </summary>
+        /// <param name="propertyName">Name of the property.</param>
+        private void OnPropertyChanged(string? propertyName) =>
             PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
     }
 }

CoreViewer/AnalyzerViewModel.cs

@@ -240,7 +240,7 @@ private void ApplyFilter()
                     openFile: _ => HandleOpen(d.Name),
                     ignore: _ => HandleIgnore(d.Name),
                     fix: FixableAnalyzers.Contains(d.Name)
-                        ? _ => global::CoreViewer.AnalyzerViewModel.HandleFix(d.Name)
+                        ? _ => HandleFix(d.Name)
                         : null));
             }
         }

Imaging/DirectBitmap.cs

@@ -130,7 +130,7 @@ public DirectBitmap(string filePath)
         }
 
         /// <inheritdoc />
-        public Pixel32[] Bits { get; private set; }
+        public Pixel32[]? Bits { get; private set; }
 
         /// <summary>
         ///     Gets the bitmap.

Imaging/DirectBitmapCore.cs

@@ -6,6 +6,8 @@
  * PROGRAMER:   Peter Geinitz (Wayfarer)
  */
 
+// ReSharper disable MemberCanBePrivate.Global
+
 using System;
 using System.Collections.Generic;
 using System.Linq;
@@ -67,8 +69,6 @@ internal static unsafe void SetPixelsAdaptive(
             IEnumerable<PixelData> pixels,
             int threshold)
         {
-            if (pixels == null) return;
-
             IEnumerable<PixelData> pixelCollection = pixels;
 
             int count;
@@ -116,9 +116,9 @@ internal static unsafe void SetPixelsAdaptive(
         /// <param name="height">The height of the image.</param>
         /// <param name="pixels">Enumerable of (x, y, Pixel32) tuples to set.</param>
         internal static void SetPixelsSimd(Pixel32[] bits, int width, int height,
-            IEnumerable<(int x, int y, Pixel32 color)> pixels)
+            IEnumerable<(int x, int y, Pixel32 color)>? pixels)
         {
-            if (bits == null || pixels == null) return;
+            if (pixels == null) return;
 
             // Group pixels by row and color to make contiguous writes cache-friendly
             var grouped = pixels
@@ -168,11 +168,11 @@ internal static unsafe void SetPixelsUnsafe(
             Pixel32[] bits,
             int width,
             int height,
-            IEnumerable<PixelData> pixels,
+            IEnumerable<PixelData>? pixels,
             byte* backBuffer = null,
             int stride = 0)
         {
-            if (bits == null || pixels == null) return;
+            if (pixels == null) return;
 
             if (backBuffer != null && stride <= 0)
                 throw new ArgumentException("Stride must be positive when backBuffer is provided.");
@@ -199,6 +199,8 @@ internal static unsafe void SetPixelsUnsafe(
 
         /// <summary>
         /// Sets the pixels unsafe span.
+        /// Could be private but is internal for testing purposes.
+        /// Uses unsafe code to set pixels from a ReadOnlySpan of PixelData, which can be stackalloc'd for small batches to avoid heap allocations.
         /// </summary>
         /// <param name="bits">The bits.</param>
         /// <param name="width">The width.</param>
@@ -211,8 +213,6 @@ internal static unsafe void SetPixelsUnsafeSpan(
             int height,
             ReadOnlySpan<PixelData> pixels)
         {
-            if (bits == null) return;
-
             fixed (Pixel32* pBits = bits)
             {
                 for (int i = 0; i < pixels.Length; i++)

Imaging/DirectBitmapImage.cs

@@ -87,7 +87,7 @@ public DirectBitmapImage(int width, int height)
         /// </summary>
         /// <param name="bits">The pixel array (BGRA32).</param>
         /// <param name="width">The width of the image.</param>
-        public DirectBitmapImage(Pixel32[] bits, int width)
+        public DirectBitmapImage(Pixel32[]? bits, int width)
         {
             if (bits == null) throw new ArgumentNullException(nameof(bits));
             if (width <= 0) throw new ArgumentOutOfRangeException(nameof(width));
@@ -115,7 +115,7 @@ public DirectBitmapImage(Pixel32[] bits, int width)
         /// <summary>
         ///     Gets the raw pixel buffer.
         /// </summary>
-        public Pixel32[] Bits { get; }
+        public Pixel32[]? Bits { get; }
 
         /// <summary>
         ///     Gets the cached converted BitmapImage.
@@ -219,6 +219,7 @@ public void ApplyColorMatrix(float[][] matrix)
         /// Sets pixels from PixelData collection efficiently.
         /// </summary>
         /// <param name="pixels">Collection of PixelData (x, y, RGBA).</param>
+        /// <param name="threshold">The threshold.</param>
         public void SetPixels(IEnumerable<PixelData> pixels, int threshold = 64)
         {
             lock (_syncLock)
@@ -331,7 +332,6 @@ private void Dispose(bool disposing)
             if (disposing && _bitsHandle.IsAllocated)
             {
                 _cachedImage = null;
-
             }
 
             if (_bitsHandle.IsAllocated)