format and cleanup

Author: LoneWandererProductions

CommonLibraryGuiTests/Image/example Polaris.png

@@ -31,7 +31,8 @@ public sealed class WhoAmIExtension : ICommandExtension
         public string Namespace => "System";
 
         /// <inheritdoc />
-        public CommandResult Invoke(ICommand command, string[] extensionArgs, Func<string[], CommandResult> executor, string[] commandArgs)
+        public CommandResult Invoke(ICommand command, string[] extensionArgs, Func<string[], CommandResult> executor,
+            string[] commandArgs)
         {
             if (extensionArgs.Length == 0)
             {

CommonLibraryGuiTests/Image/example.png

@@ -32,13 +32,13 @@
         <!-- Log Area -->
         <ScrollViewer x:Name="ScrollViewer"
                       VerticalScrollBarVisibility="Auto">
-            <TextBox  x:Name="LogText"
-                       Cursor="Arrow" 
-                       IsReadOnly="True"
-                       Focusable="True"
-                       FontFamily="Consolas"
-                       TextWrapping="Wrap"
-                       Margin="10" />
+            <TextBox x:Name="LogText"
+                     Cursor="Arrow"
+                     IsReadOnly="True"
+                     Focusable="True"
+                     FontFamily="Consolas"
+                     TextWrapping="Wrap"
+                     Margin="10" />
         </ScrollViewer>
     </DockPanel>
 </Window>

CoreBuilder/Extensions/WhoAmIExtension.cs

@@ -2,14 +2,22 @@
  * COPYRIGHT:   See COPYING in the top level directory
  * PROJECT:     DataFormatter
  * FILE:        FormatterApiFacade.cs
- * PURPOSE:     Api Facade for the DataFormatter library
+ * PURPOSE:     Api Façade for the DataFormatter library
  * PROGRAMER:   Peter Geinitz (Wayfarer)
  */
 
+// ReSharper disable UnusedMember.Global
+// ReSharper disable UnusedType.Global
+
 using System.Collections.Generic;
+using System.Threading.Tasks;
+
 
 namespace DataFormatter
 {
+    /// <summary>
+    /// Central API Façade for the DataFormatter library
+    /// </summary>
     public static class FormatterApiFacade
     {
         /// <summary>
@@ -26,7 +34,8 @@ public static class FormatterApiFacade
         /// <param name="file">The file.</param>
         /// <param name="data">The data.</param>
         /// <param name="sep">The sep.</param>
-        public static void WriteCsv(string file, IEnumerable<List<string>> data, string sep) => CsvHandler.WriteCsv(file, data, sep);
+        public static void WriteCsv(string file, IEnumerable<List<string>> data, string sep) =>
+            CsvHandler.WriteCsv(file, data, sep);
 
         /// <summary>
         /// Reads the CSV with layers.
@@ -52,20 +61,20 @@ public static void WriteCsvWithLayers(string file, char sep, List<List<string>>
         /// </summary>
         /// <param name="path">The path.</param>
         /// <returns>the values as String[]. Can return null.</returns>
-        public static IEnumerable<string> ReadFile(string path) => ReadText.ReadFile(path);
+        public static IEnumerable<string>? ReadFile(string path) => ReadText.ReadFile(path);
 
         /// <summary>
         /// Writes the file.
         /// </summary>
         /// <param name="path">The path.</param>
         /// <param name="content">The content.</param>
-        public static void WriteFile(string path, IEnumerable<string> content) => ReadText.WriteFile(path, content);
+        public static async Task WriteFile(string path, IEnumerable<string> content) => await ReadText.WriteFile(path, content);
 
         /// <summary>
         /// Reads the object.
         /// </summary>
         /// <param name="path">The path.</param>
         /// <returns>Readable Obj File</returns>
-        public static ObjFile ReadObj(string path) => ReaderObj.ReadObj(path);
+        public static ObjFile? ReadObj(string path) => ReaderObj.ReadObj(path);
     }
 }

CoreBuilder/UI/LogWindow.xaml

@@ -23,7 +23,7 @@ internal static class FileHelper
         /// <summary>
         /// The number regex
         /// </summary>
-        private static readonly Regex _numberRegex = new Regex(@"\d+", RegexOptions.Compiled);
+        private static readonly Regex NumberRegex = new(@"\d+", RegexOptions.Compiled);
 
         /// <summary>
         /// Gets the files by extension full path.
@@ -103,7 +103,7 @@ internal static List<string> SortNaturally(this IEnumerable<string> paths)
         /// <returns>Extracted numbers.</returns>
         private static int ExtractNumber(string name)
         {
-            var match = _numberRegex.Match(name);
+            var match = NumberRegex.Match(name);
             return match.Success ? int.Parse(match.Value) : int.MaxValue;
         }
     }

DataFormatter/FormatterApiFacade.cs

@@ -330,7 +330,6 @@ private static Bitmap ApplySobel(Bitmap originalImage)
                     {
                         for (var i = -1; i <= 1; i++)
                         {
-                            var pixel = sourceBuffer.GetPixel(x + i, y + j);
                             var (r, g, b, a) = sourceBuffer.GetPixel(x + i, y + j);
 
                             int grayValue = r; // grayscale

Imaging/Helpers/FileHelper.cs

@@ -7,8 +7,6 @@
 */
 
 using System;
-using System.Collections.Generic;
-using System.Diagnostics;
 using System.Drawing;
 
 namespace Imaging.Helpers
@@ -111,26 +109,5 @@ private static Bitmap ProcessImage(Bitmap image, Action<ColorHsv> pixelOp)
 
             return result.Bitmap;
         }
-
-
-        /// <summary>
-        ///     Applies the pixel changes.
-        /// </summary>
-        /// <param name="result">The result.</param>
-        /// <param name="pixelsToSet">The pixels to set.</param>
-        /// <returns>Processed Image</returns>
-        private static Bitmap ApplyPixelChanges(DirectBitmap result, List<(int x, int y, Color color)> pixelsToSet)
-        {
-            try
-            {
-                result.SetPixelsSimd(pixelsToSet);
-                return result.Bitmap;
-            }
-            catch (Exception ex)
-            {
-                Trace.WriteLine($"{ImagingResources.ErrorPixel} {ex.Message}");
-                return null;
-            }
-        }
     }
 }

Imaging/Helpers/FiltersStream.cs

@@ -145,7 +145,7 @@ public sealed class FrameInfo
         /// <value>
         ///     The delay time.
         /// </value>
-        public double DelayTime { get; set; } // Delay time in seconds
+        public double DelayTime { get; init; } // Delay time in seconds
 
 
         /// <summary>

Imaging/Helpers/ImageStreamHsv.cs

@@ -6,18 +6,22 @@
  * PROGRAMER:   Peter Geinitz (Wayfarer)
  */
 
+// ReSharper disable UnusedMember.Global
+// ReSharper disable UnusedType.Global
+
 using System;
 using System.Collections.Generic;
 using System.Drawing;
 using System.Drawing.Imaging;
+using System.Linq;
 using System.Threading.Tasks;
 using System.Windows.Media.Imaging;
 using Imaging.Enums;
 
 namespace Imaging
 {
     /// <summary>
-    ///     Unified facade for the Imaging engine.
+    ///     Unified façade for the Imaging engine.
     ///     This class provides a stable public API for common image processing tasks,
     ///     including loading, saving, conversion, resizing, filtering, pixel manipulation,
     ///     GIF handling, blending, and texture generation.
@@ -26,8 +30,8 @@ namespace Imaging
     /// </summary>
     public static class ImagingFacade
     {
-
         #region Register
+
         /// <summary>
         /// Gets the singleton instance of the <see cref="ImageRegister"/>.
         /// Allows querying and modifying filter and texture settings globally.
@@ -46,7 +50,8 @@ public static class ImagingFacade
         /// </summary>
         /// <param name="filter">The filter type.</param>
         /// <param name="config">The new filter configuration.</param>
-        public static void SetFilterSettings(FiltersType filter, FiltersConfig config) => Register.SetSettings(filter, config);
+        public static void SetFilterSettings(FiltersType filter, FiltersConfig config) =>
+            Register.SetSettings(filter, config);
 
         /// <summary>
         /// Retrieves all available filters.
@@ -73,7 +78,8 @@ public static class ImagingFacade
         /// </summary>
         /// <param name="texture">The texture type.</param>
         /// <param name="config">The new texture configuration.</param>
-        public static void SetTextureSettings(TextureType texture, TextureConfiguration config) => Register.SetSettings(texture, config);
+        public static void SetTextureSettings(TextureType texture, TextureConfiguration config) =>
+            Register.SetSettings(texture, config);
 
         /// <summary>
         /// Gets the property names used by a specific texture type.
@@ -104,6 +110,7 @@ public static class ImagingFacade
         /// Gets the last error message recorded by the Imaging engine.
         /// </summary>
         public static string? LastError => Register.LastError;
+
         #endregion
 
         #region Load / Save
@@ -191,7 +198,7 @@ public static Bitmap Crop(Bitmap image, int x, int y, int width, int height)
         /// <param name="image">The source bitmap.</param>
         /// <param name="filter">The filter type to apply.</param>
         /// <returns>The filtered <see cref="Bitmap"/>.</returns>
-        public static Bitmap ApplyFilter(Bitmap image, FiltersType filter)
+        public static Bitmap? ApplyFilter(Bitmap image, FiltersType filter)
             => new ImageRender().FilterImage(image, filter);
 
         /// <summary>
@@ -203,7 +210,8 @@ public static Bitmap ApplyFilter(Bitmap image, FiltersType filter)
         /// <param name="shapeParams">Optional parameters for the mask shape.</param>
         /// <param name="startPoint">Optional start point for the filter.</param>
         /// <returns>The filtered <see cref="Bitmap"/>.</returns>
-        public static Bitmap ApplyFilterArea(Bitmap image, FiltersType filter, MaskShape shape, object shapeParams, System.Drawing.Point? startPoint = null)
+        public static Bitmap ApplyFilterArea(Bitmap image, FiltersType filter, MaskShape shape, object shapeParams,
+            Point? startPoint = null)
             => new ImageRender().FilterImageArea(image, null, null, filter, shape, shapeParams, startPoint);
 
         #endregion
@@ -216,7 +224,7 @@ public static Bitmap ApplyFilterArea(Bitmap image, FiltersType filter, MaskShape
         /// <param name="image">The bitmap.</param>
         /// <param name="p">The pixel location.</param>
         /// <returns>The <see cref="Color"/> of the pixel.</returns>
-        public static Color GetPixel(Bitmap image, System.Drawing.Point p)
+        public static Color GetPixel(Bitmap image, Point p)
             => new ImageRender().GetPixel(image, p);
 
         /// <summary>
@@ -225,7 +233,7 @@ public static Color GetPixel(Bitmap image, System.Drawing.Point p)
         /// <param name="image">The bitmap.</param>
         /// <param name="p">The pixel location.</param>
         /// <param name="color">The color to set.</param>
-        public static void SetPixel(Bitmap image, System.Drawing.Point p, Color color)
+        public static void SetPixel(Bitmap image, Point p, Color color)
             => new ImageRender().SetPixel(image, p, color);
 
         /// <summary>
@@ -250,7 +258,7 @@ public static void FloodFill(Bitmap image, int x, int y, Color newColor)
         /// <param name="x">X-coordinate for overlay placement.</param>
         /// <param name="y">Y-coordinate for overlay placement.</param>
         /// <returns>The combined <see cref="Bitmap"/>.</returns>
-        public static Bitmap Combine(Bitmap baseImage, Bitmap overlay, int x, int y)
+        public static Bitmap? Combine(Bitmap baseImage, Bitmap overlay, int x, int y)
             => new ImageRender().CombineBitmap(baseImage, overlay, x, y);
 
         /// <summary>
@@ -316,8 +324,7 @@ public static async Task<IReadOnlyList<Bitmap>> LoadGifAsync(string path)
             var sources = await new ImageRender().LoadGifAsync(path);
 
             var frames = new List<Bitmap>(sources.Count);
-            foreach (var src in sources)
-                frames.Add(ImageExtension.ToBitmap((BitmapImage)src));
+            frames.AddRange(sources.Select(src => ((BitmapImage)src).ToBitmap()));
 
             return frames;
         }
@@ -344,7 +351,8 @@ public static void CreateGif(IEnumerable<FrameInfo> frames, string target)
         /// <param name="shapeParams">Optional parameters for the shape.</param>
         /// <param name="startPoint">Optional starting point.</param>
         /// <returns>The generated texture as a <see cref="Bitmap"/>.</returns>
-        public static Bitmap GenerateTexture(int width, int height, TextureType type, MaskShape shape, object shapeParams, System.Drawing.Point? startPoint = null)
+        public static Bitmap? GenerateTexture(int width, int height, TextureType type, MaskShape shape,
+            object shapeParams, Point? startPoint = null)
             => new TextureGenerator().GenerateTexture(width, height, type, shape, startPoint, shapeParams);
 
         #endregion