fix up another test and another function

Author: LoneWandererProductions

CommonLibraryTests/IoFileSearch.cs

@@ -146,36 +146,36 @@ public async Task GetFilesByExtensionWithoutExtensionAsync()
     }
 
     /// <summary>
-    ///     Simple Check for getting files Contains in a Folder
+    /// Simple Check for getting files contained in a folder.
     /// </summary>
     [TestMethod]
-    public void GetAllSubfolders()
+    public void GetAllSubfoldersDeterministic()
     {
-        var check = false;
-        var list = FileHandleSearch.GetAllSubfolders(Directory.GetCurrentDirectory());
+        // Use a known path for testing (deterministic)
+        var currentDir = Directory.GetCurrentDirectory();
 
-        if (list == null)
-        {
-            Assert.Fail("Null Reference");
-        }
+        // Navigate to the project folder (assume tests are in bin\Debug\netX.Y)
+        var projectRoot = Directory.GetParent(currentDir)?.Parent?.Parent?.FullName;
+        Assert.IsNotNull(projectRoot, "Could not determine project root directory.");
 
-        if (list.Count > 0)
-        {
-            check = true;
-        }
+        // Retrieve all subfolders using your method
+        var list = FileHandleSearch.GetAllSubfolders(projectRoot);
 
-        Assert.IsTrue(check, "Did not get all Folders");
+        Assert.IsNotNull(list, "GetAllSubfolders returned null.");
+        Assert.IsTrue(list.Count > 0, "Did not get any subfolders.");
 
-        var path = DirectoryInformation.GetParentDirectory(1);
-        Assert.IsTrue(path.EndsWith("\\CoreLibrary\\CommonLibraryTests\\bin", StringComparison.Ordinal),
-            $"Wrong Directory Name: {path}");
+        // Test DirectoryInformation.GetParentDirectory deterministically
+        // Use projectRoot as starting point
+        var parent1 = DirectoryInformation.GetParentDirectoryFromPath(projectRoot, 1);
+        Assert.IsTrue(parent1.EndsWith("\\CoreLibrary", StringComparison.Ordinal),
+            $"Wrong Directory Name: {parent1}");
 
-        path = DirectoryInformation.GetParentDirectory(2);
-
-        Assert.IsTrue(path.EndsWith("\\CoreLibrary\\CommonLibraryTests", StringComparison.Ordinal),
-            $"Wrong Directory Name: {path}");
+        var parent2 = DirectoryInformation.GetParentDirectoryFromPath(projectRoot, 2);
+        Assert.IsTrue(parent2.EndsWith("\\Source", StringComparison.Ordinal),
+            $"Wrong Directory Name: {parent2}");
     }
 
+
     /// <summary>
     ///     Gets the file information.
     /// </summary>

FileHandler/DirectoryInformation.cs

@@ -3,56 +3,58 @@
 * PROJECT:     FileHandler
 * FILE:        FileHandler/DirectoryInformation.cs
 * PURPOSE:     Generic System Functions for Directories
-* PROGRAMER:   Peter Geinitz (Wayfarer)
+* PROGRAMER:   Peter Geinitz (Wayfarer) – Refactor by ChatGPT
 */
 
-// ReSharper disable UnusedType.Global
-
 using System;
 using System.Diagnostics;
 using System.IO;
 
 namespace FileHandler;
 
 /// <summary>
-///     The directory information class.
+/// Directory helper class with testable parent retrieval
 /// </summary>
 public static class DirectoryInformation
 {
     /// <summary>
-    ///     Returns Path at the defined level height
+    /// Returns a parent directory at the specified level from the current working directory.
     /// </summary>
-    /// <param name="level">Height of Path</param>
-    /// <returns>Returns Path at the current height, can return null.</returns>
-    /// <exception cref="FileHandlerException">No Correct Path was provided</exception>
+    /// <param name="level">Levels to go up</param>
+    /// <returns>Parent directory path</returns>
     public static string GetParentDirectory(int level)
-    {
-        var root = Directory.GetCurrentDirectory();
-
-        if (string.IsNullOrEmpty(root))
-        {
-            throw new FileHandlerException($"{FileHandlerResources.ErrorGetParentDirectory} {root}");
-        }
+        => GetParentDirectoryFromPath(Directory.GetCurrentDirectory(), level);
 
-        var path = Directory.GetParent(root)?.ToString();
+    /// <summary>
+    /// Returns a parent directory at the specified level from a given path.
+    /// This method is safe for unit testing with arbitrary paths.
+    /// </summary>
+    /// <param name="startPath">The path to start from</param>
+    /// <param name="level">Levels to go up</param>
+    /// <returns>Parent directory path</returns>
+    /// <exception cref="FileHandlerException"></exception>
+    public static string GetParentDirectoryFromPath(string startPath, int level)
+    {
+        if (string.IsNullOrEmpty(startPath))
+            throw new FileHandlerException($"{FileHandlerResources.ErrorGetParentDirectory}: startPath was empty");
 
-        if (string.IsNullOrEmpty(path))
-        {
-            throw new FileHandlerException($"{FileHandlerResources.ErrorGetParentDirectory} {path}");
-        }
+        var path = startPath;
 
         try
         {
             for (var i = 0; i < level; i++)
             {
-                path = Directory.GetParent(path!)?.ToString();
+                var parent = Directory.GetParent(path);
+                if (parent == null)
+                    throw new FileHandlerException($"{FileHandlerResources.ErrorGetParentDirectory}: reached root at level {i}");
+                path = parent.FullName;
             }
         }
-        catch (Exception ex) when (ex is UnauthorizedAccessException or DirectoryNotFoundException or IOException)
+        catch (Exception ex) when (ex is UnauthorizedAccessException or DirectoryNotFoundException or IOException or FileHandlerException)
         {
-            FileHandlerRegister.AddError(nameof(GetParentDirectory), path, ex);
+            FileHandlerRegister.AddError(nameof(GetParentDirectoryFromPath), path, ex);
             Trace.WriteLine(ex);
-            throw new FileHandlerException($"{FileHandlerResources.ErrorGetParentDirectory} {ex}");
+            throw new FileHandlerException($"{FileHandlerResources.ErrorGetParentDirectory}: {ex.Message}");
         }
 
         return path;