Skip to content

Fix typos and update unknown-attributes bitmask in Insyde FDM parser#481

Merged
NikolajSchlej merged 2 commits into
LongSoft:new_enginefrom
yeggor:fix/typos-and-unknown-attributes-mask
Jul 5, 2026
Merged

Fix typos and update unknown-attributes bitmask in Insyde FDM parser#481
NikolajSchlej merged 2 commits into
LongSoft:new_enginefrom
yeggor:fix/typos-and-unknown-attributes-mask

Conversation

@yeggor

@yeggor yeggor commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Hi! Thanks for adding support for Insyde FDM. This PR contains minor improvements:

  • fix typos ("Firmare" -> "Firmware", "atributes" -> "attributes")
  • fix GUID comments so they match their byte arrays
  • replace the unknown-attributes mask ((UINT32)(0xFFFFFFFFC) with a self-documenting ~(IGNORED | MODIFIABLE) mask
  • fix compilation warnings from QHexView

@NikolajSchlej NikolajSchlej merged commit 8293d4e into LongSoft:new_engine Jul 5, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants