Skip to content

Commit 7996111

Browse files
committed
Simplify runtime route handling
1 parent f111056 commit 7996111

3 files changed

Lines changed: 294 additions & 395 deletions

File tree

src/admin/deployment_detail_release_field_support.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ export function renderCanvasEnvironmentField(input: {
164164
<select id="canvas-environment" name="canvasEnvironment" ${
165165
input.disabled ? 'disabled' : ''
166166
} ${renderFieldAriaInvalid(input.editorState, 'canvasEnvironment')}
167-
}>
167+
>
168168
${input.supportedCanvasEnvironments
169169
.map(
170170
(environment) =>

src/admin/deployment_detail_render_test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ Deno.test('deployment page keeps shared copy neutral while scoping Canvas, Moodl
6868
assertStringIncludes(html, 'Advanced Canvas settings');
6969
assertStringIncludes(html, 'Configuration URL');
7070
assertStringIncludes(html, 'Canvas environment');
71+
assertStringIncludes(html, '<select id="canvas-environment" name="canvasEnvironment"');
72+
assertFalse(html.includes('name="canvasEnvironment" \n }'));
7173
assertStringIncludes(html, binding.issuer);
7274
assertStringIncludes(html, 'chip-status-healthy');
7375
assertStringIncludes(html, 'Recent launches');

0 commit comments

Comments
 (0)