fix(ios): revert dotlottie-ios dependency from SPM back to CocoaPods#69
Merged
Merged
Conversation
PR #57 switched the iOS dotlottie-ios dependency to a SwiftPM product via the spm_dependency helper. On Xcode 26 this makes DotLottiePlayer.xcframework get processed twice during an archive (once by the SwiftPM DotLottie target, once by the dotlottie-react-native pod target). The archive step collects each embedded xcframework signature into one flat Signatures/ folder, so the two identically named DotLottiePlayer.xcframework-ios.signature files collide and archiving fails with "File exists" (exit 70) (#66). Consuming the player through the LottieFiles-dotLottie-iOS CocoaPods pod embeds the xcframework exactly once, fixing the archive failure at the root. - podspec: spm_dependency(...) -> s.dependency 'LottieFiles-dotLottie-iOS', '~> 0.15.6' - example/ios/Podfile: restore ENV-based linkage (drop forced dynamic frameworks) - plugins/withDotLottie.js: correct now-inaccurate SPM comment
🦋 Changeset detectedLatest commit: dc228f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LottieFiles-dotLottie-iOS 0.15.7 is now resolvable on the CocoaPods CDN, so raise the floor to ~> 0.15.7 to match the version the previous SPM setup required.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the iOS
dotlottie-iosdependency from Swift Package Manager back to theLottieFiles-dotLottie-iOSCocoaPods pod, undoing #57.Why — fixes #66
#57 pulled the player as a SwiftPM product via the
spm_dependencyhelper. With that setup,DotLottiePlayer.xcframeworkis processed twice in a single build — once by the SwiftPMDotLottietarget and once by thedotlottie-react-nativepod target. On Xcode 26 the archive step collects every embedded xcframework's signature into one flat<archive>/Signatures/folder, so the two identically-namedDotLottiePlayer.xcframework-ios.signaturefiles collide:Consuming the player through the CocoaPods pod embeds the xcframework exactly once, so the collision can't occur — fixing the archive failure at the root rather than patching the symptom with a signature-removal script phase.
Changes
dotlottie-react-native.podspec:spm_dependency(...)→s.dependency 'LottieFiles-dotLottie-iOS', '~> 0.15.6'example/ios/Podfile: restored the originalENV['USE_FRAMEWORKS']linkage block (dropped the forceduse_frameworks! :dynamicand theprojectworkaround SPM needed)plugins/withDotLottie.js: corrected the now-inaccurate SPM comment (behavior unchanged)example/iosPods (lockfile + pbxproj) — no SwiftPM package references remainFollow-up — bump to 0.15.7
LottieFiles-dotLottie-iOS 0.15.7has been published to the CocoaPods trunk (repo podspec sync: LottieFiles/dotlottie-ios#125), matching the version the SPM setup floored at. It's pinned to~> 0.15.6here only because the CocoaPods CDN version index hasn't propagated0.15.7yet; a follow-up commit will bump this to~> 0.15.7once it's resolvable.Closes #66