Merge pull request #3349 from ushen-pyj/master

fix(parser): 修复文档参数绑定的重复问题

Author: sumneko

changelog.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 <!-- Add all new changes here. They will be moved under a version at release -->
+* `FIX` Deduplicate documentation bindings for parameters
 * `FIX` Correct `math.type` meta return annotation to use `nil` instead of the string literal `'nil'`
 * `FIX` Fix initial `nameStyle.config` not getting loaded in the appropriate workspace.
 * `FIX` string.match and string.gmatch may return `string|integer?` [#3357](https://github.com/LuaLS/lua-language-server/issues/3357)

script/parser/luadoc.lua

@@ -2199,6 +2199,38 @@ local function bindDocWithSources(sources, binded)
     end
 end
 
+local docsDedupe = function (sources)
+    local removeByValue = function(bindDocs, value)
+        for i = #bindDocs, 1, -1 do
+            if bindDocs[i] == value then
+                table.remove(bindDocs, i)
+                break
+            end
+        end
+    end
+    for _, source in ipairs(sources) do
+        if source.bindDocs then
+            local docs = {}
+            for i = #source.bindDocs, 1, -1 do
+                local doc = source.bindDocs[i]
+                if doc.type == 'doc.param' and doc.param[1] then
+                    local param1 = doc.param[1]
+                    if docs[param1] then
+                        local old = docs[param1]
+                        if old.virtual and not doc.virtual then
+                            removeByValue(source.bindDocs, old)
+                        elseif not old.virtual and doc.virtual then
+                            removeByValue(source.bindDocs, doc)
+                            doc = old
+                        end
+                    end
+                    docs[param1] = doc
+                end
+            end
+        end
+    end
+end
+
 local bindDocAccept = {
     'local'     , 'setlocal'  , 'setglobal',
     'setfield'  , 'setmethod' , 'setindex' ,
@@ -2253,6 +2285,7 @@ local function bindDocs(state)
             end
         end
     end
+    docsDedupe(sources)
 end
 
 local function findTouch(state, doc)