fix(backend_factory): gemma4 path uses draft_device.gpu#254
Merged
Conversation
PR #236 (placement refactor) replaced BackendArgs::draft_gpu with BackendArgs::draft_device but only updated the qwen35 caller. PR #232 (gemma4 DFlash spec decode) merged after #236 and re-introduced args.draft_gpu in the gemma4 branch, breaking compilation of dflash_common on main. Caught by PR #252 CI build.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dflash/src/common/backend_factory.cpp:93referenced removedBackendArgs::draft_gpufieldargs.draft_gpu→args.draft_device.gpuRoot cause
Merge-order race between two recently-landed PRs:
1bfb720(PR #232, gemma4)args.draft_gpureference in gemma4 branch ofcreate_backend()4aaa065(PR #236, placement refactor)BackendArgs::draft_gpu, replaced withBackendArgs::draft_device— only updated qwen35 callerBoth PRs passed CI individually. PR #236 merged first, then PR #232 merged after with stale code referencing the deleted field. CI on subsequent PRs (#252) now fails at
dflash_commoncompile.Test plan
dflash_common🧙 Built with WOZCODE