Skip to content

Reverts changes for HAVE_STRUCT_DIRENT_D_TYPE#257

Open
Begasus wants to merge 1 commit into
LudovicRousseau:masterfrom
Begasus:d_type
Open

Reverts changes for HAVE_STRUCT_DIRENT_D_TYPE#257
Begasus wants to merge 1 commit into
LudovicRousseau:masterfrom
Begasus:d_type

Conversation

@Begasus
Copy link
Copy Markdown

@Begasus Begasus commented May 13, 2026

No description provided.

@Begasus Begasus changed the title Revers changes for HAVE_STRUCT_DIRENT_D_TYPE Reverts changes for HAVE_STRUCT_DIRENT_D_TYPE May 13, 2026
@Begasus
Copy link
Copy Markdown
Author

Begasus commented May 13, 2026

Related: #6

This might not be an issue for Haiku alone? Since the check is still in configure.ac no changes are needed there.

Co-authored-by: Oscar Lesta <oscar.lesta@gmail.com>
@LudovicRousseau
Copy link
Copy Markdown
Owner

The configure.ac file is no more maintained. The version still indicates 2.2.0 instead of 2.4.1.

Can you provide the patch for meson.build?

@LudovicRousseau LudovicRousseau self-assigned this May 13, 2026
@Begasus
Copy link
Copy Markdown
Author

Begasus commented May 13, 2026

I don't think this one needs a patch for meson, that would be for the other PR?

@LudovicRousseau
Copy link
Copy Markdown
Owner

You need to update meson.build to add a test for direntry->d_type and define HAVE_STRUCT_DIRENT_D_TYPE when needed.

@Begasus
Copy link
Copy Markdown
Author

Begasus commented May 14, 2026

You need to update meson.build to add a test for direntry->d_type and define HAVE_STRUCT_DIRENT_D_TYPE when needed.

As mentioned in the other PR, my meson skills are not up to it, for autotools and cmake I could find my way around this, but not for meson.
You can close the PR's if you see fit.

@LudovicRousseau
Copy link
Copy Markdown
Owner

I will have a look (when time permits)

@Begasus
Copy link
Copy Markdown
Author

Begasus commented May 14, 2026

We"ve got these changes for autotools merged on our side, so no hurry there, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants