Skip to content

Commit f3ca2f3

Browse files
Fix compiler warning
src/pykcs11_wrap.cpp:5623:3: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations] sprintf(szVal, "%d.%d", self->libraryVersion.major, self->libraryVersion.minor); ^
1 parent d78b729 commit f3ca2f3

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/pykcs11.i

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ typedef struct CK_INFO {
101101
PyKCS11String GetLibraryVersion()
102102
{
103103
char szVal[10];
104-
sprintf(szVal, "%d.%d", self->libraryVersion.major, self->libraryVersion.minor);
104+
snprintf(szVal, sizeof szVal, "%d.%d", self->libraryVersion.major, self->libraryVersion.minor);
105105
return PyKCS11String(szVal);
106106
}
107107
};
@@ -129,13 +129,13 @@ typedef struct CK_SLOT_INFO {
129129
PyKCS11String GetHardwareVersion()
130130
{
131131
char szVal[10];
132-
sprintf(szVal, "%d.%02d", self->hardwareVersion.major, self->hardwareVersion.minor);
132+
snprintf(szVal, sizeof szVal, "%d.%02d", self->hardwareVersion.major, self->hardwareVersion.minor);
133133
return PyKCS11String(szVal);
134134
}
135135
PyKCS11String GetFirmwareVersion()
136136
{
137137
char szVal[10];
138-
sprintf(szVal, "%d.%02d", self->firmwareVersion.major, self->firmwareVersion.minor);
138+
snprintf(szVal, sizeof szVal, "%d.%02d", self->firmwareVersion.major, self->firmwareVersion.minor);
139139
return PyKCS11String(szVal);
140140
}
141141
};
@@ -184,7 +184,7 @@ typedef struct CK_TOKEN_INFO {
184184
PyKCS11String GetFirmwareVersion()
185185
{
186186
char szVal[10];
187-
sprintf(szVal, "%d.%02d", self->firmwareVersion.major, self->firmwareVersion.minor);
187+
snprintf(szVal, sizeof szVal, "%d.%02d", self->firmwareVersion.major, self->firmwareVersion.minor);
188188
return PyKCS11String(szVal);
189189
}
190190
PyKCS11String GetUtcTime()

0 commit comments

Comments
 (0)