Skip to content

fix: Missing default props on sdk request, when option prop passed #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SirSerje wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Missing default props on sdk request, when option prop passed #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f640eec
#46 Missing default props on sdk request, when option prop
SirSerje Dec 23, 2019
6d40400
refactor addPaypalSdk method
SirSerje Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,17 +203,18 @@ class PayPalButton extends React.Component<PayPalButtonProps, PayPalButtonState>

private addPaypalSdk() {
const { options, onButtonReady } = this.props;
const queryParams: string[] = [];

// replacing camelCase with dashes
Object.keys(options).forEach(k => {
const name = k.split(/(?=[A-Z])/).join("-").toLowerCase();
queryParams.push(`${name}=${options[k]}`);
});
const separator = (key: string): string => key.split(/(?=[A-Z])/).join("-").toLowerCase();
const createQueryParam = (object: object, modifier: Function): string => Object.entries(object)
.reduce((acc: string [], [key, value]: [string, string]) => {
acc.push(`${modifier(key)}=${value}`);
return acc;
}, []).join("&");
const queryParam = createQueryParam({...PayPalButton.defaultProps.options, ...options}, separator);

const script = document.createElement("script");
script.type = "text/javascript";
script.src = `https://www.paypal.com/sdk/js?${queryParams.join("&")}`;
script.src = `https://www.paypal.com/sdk/js?${queryParam}`;
script.async = true;
script.onload = () => {
this.setState({ isSdkReady: true });
Expand All @@ -225,7 +226,7 @@ class PayPalButton extends React.Component<PayPalButtonProps, PayPalButtonState>
script.onerror = () => {
throw new Error("Paypal SDK could not be loaded.");
};

document.body.appendChild(script);
}
}
Expand Down