Commit 5407dab
authored
fix(deploy): resolve production routing and asset paths for GitHub Pages
## π Bug Fix
This MR addresses critical issues preventing the application from rendering correcty on GitHub Pages (subdirectory deployment).
## π Changes
### 1. π£οΈ Routing (Subdirectory Support)
- **Vite:** Updated `base` configuration to `/test-abb/` to serve assets from the correct subdirectory.
- **React Router:** Added `basename="/test-abb"` to ensure client-side routing works within the hosted folder.
- **Cypress:** Updated `baseUrl` and navigation assertions in E2E tests to match the new subdirectory structure.
### 2. πΌοΈ Asset Management
- **Broken Images:** Moved `public` images ([banner.jpg](cci:7://file:///home/lupy/Documentos/CV/tech_test_ABB/test-abb/public/banner.jpg:0:0-0:0), [hero.png](cci:7://file:///home/lupy/Documentos/CV/tech_test_ABB/test-abb/public/hero.png:0:0-0:0), etc.) to `src/assets`.
- **Import Strategy:** Refactored components to import images directly. This forces Vite to hash and bundle them correctly, resolving 404 errors in production.
## β
Verification
- **Local:** Verified via `yarn build` + `yarn preview`.
- **CI/CD:** Pipeline passing (all E2E tests updated and green).12 files changed
Lines changed: 20 additions & 13 deletions
File tree
- cypress/e2e
- src
- assets
- components
- pages
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
18 | | - | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
File renamed without changes.
File renamed without changes.
File renamed without changes.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
4 | 6 | | |
5 | 7 | | |
6 | | - | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
13 | | - | |
14 | | - | |
15 | | - | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
78 | 79 | | |
79 | 80 | | |
80 | 81 | | |
81 | | - | |
| 82 | + | |
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
30 | | - | |
| 31 | + | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
0 commit comments