Fix release tarball version naming#188
Draft
akobrin1 wants to merge 7 commits into
Draft
Conversation
Record governance helper account details in the validator registry during setup and make proposal/vote helpers resolve usable proposer and voter accounts from on-chain state. Update the remote upgrade flow for v1.20.1 binaries and keep the EVM migration status registry tolerant of migrated governance state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lumera_v1.20.1_linux_amd64.tar.gz.VERSION_TAGso both1.20.1andv1.20.1produce the expectedv1.20.1filename segment.Root Cause
The EVM release flow replaced Ignite's
--release.prefixpackaging with a manualtarcommand in the Makefile. The manual archive name used only app, OS, and arch, so tagged releases producedlumera_linux_amd64.tar.gzinstead of including the tag.Validation
make -n release RELEASE_TARGETS=linux:amd64 VERSION_TAG=1.20.1make -n release RELEASE_TARGETS=linux:amd64 VERSION_TAG=v1.20.1git diff --check