feat: update error handling in client initialization and hash computation, and comment out coverage upload steps

Author: a-ok123

.github/workflows/release.yml

@@ -63,8 +63,8 @@ jobs:
       - name: Run tests
         run: go test -v -race -coverprofile=coverage.out ./...
 
-      - name: Upload coverage
-        uses: codecov/codecov-action@v3
-        with:
-          file: ./coverage.out
+      # - name: Upload coverage
+      #   uses: codecov/codecov-action@v3
+      #   with:
+      #     file: ./coverage.out
 

.github/workflows/test.yml

@@ -35,8 +35,8 @@ jobs:
       - name: Run tests
         run: go test -v -race -coverprofile=coverage.out ./...
 
-      - name: Upload coverage
-        uses: codecov/codecov-action@v3
-        with:
-          file: ./coverage.out
+      # - name: Upload coverage
+      #   uses: codecov/codecov-action@v3
+      #   with:
+      #     file: ./coverage.out
 

blockchain/client.go

@@ -7,8 +7,8 @@ import (
 	"sync"
 	"time"
 
-	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/cosmos/cosmos-sdk/crypto/keyring"
+	sdk "github.com/cosmos/cosmos-sdk/types"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/credentials"
 	"google.golang.org/grpc/credentials/insecure"
@@ -67,7 +67,7 @@ func New(ctx context.Context, cfg Config, kr keyring.Keyring, keyName string) (*
 	// Determine if we should use TLS based on the endpoint
 	// Use TLS if: port is 443, or hostname doesn't start with "localhost"/"127.0.0.1"
 	useTLS := shouldUseTLS(cfg.GRPCAddr)
-	
+
 	var creds credentials.TransportCredentials
 	if useTLS {
 		// Use system TLS credentials for secure connections
@@ -76,7 +76,7 @@ func New(ctx context.Context, cfg Config, kr keyring.Keyring, keyName string) (*
 		// Use insecure credentials for local development
 		creds = insecure.NewCredentials()
 	}
-	
+
 	// Create gRPC connection
 	dialOpts := []grpc.DialOption{
 		grpc.WithTransportCredentials(creds),
@@ -86,7 +86,7 @@ func New(ctx context.Context, cfg Config, kr keyring.Keyring, keyName string) (*
 		),
 	}
 
-	conn, err := grpc.DialContext(ctx, cfg.GRPCAddr, dialOpts...)
+	conn, err := grpc.NewClient(cfg.GRPCAddr, dialOpts...)
 	if err != nil {
 		return nil, fmt.Errorf("failed to connect to gRPC: %w", err)
 	}
@@ -126,23 +126,23 @@ func shouldUseTLS(addr string) bool {
 	if strings.HasSuffix(addr, ":443") {
 		return true
 	}
-	
+
 	// Check if it's a local address (localhost, 127.0.0.1, or no hostname)
 	if strings.HasPrefix(addr, "localhost:") ||
 		strings.HasPrefix(addr, "127.0.0.1:") ||
 		strings.HasPrefix(addr, "0.0.0.0:") ||
 		strings.HasPrefix(addr, ":") { // Just port, implies localhost
 		return false
 	}
-	
+
 	// For any other remote address, prefer TLS by default for security
 	// This covers domain names without explicit port 443
 	if !strings.Contains(addr, "localhost") &&
 		!strings.Contains(addr, "127.0.0.1") &&
 		!strings.Contains(addr, "0.0.0.0") {
 		return true
 	}
-	
+
 	return false
 }
 

blockchain/tx.go

@@ -124,7 +124,10 @@ func (c *Client) BuildAndSignTx(ctx context.Context, msg sdk.Msg, memo string) (
 	}
 	builder.SetGasLimit(gas)
 
-	builder.SetSignatures() // clear placeholder signature
+	err = builder.SetSignatures() // clear placeholder signature
+	if err != nil {
+		return nil, fmt.Errorf("clear placeholder signature: %w", err)
+	}
 
 	// Ensure a minimum fee to satisfy chain requirements
 	fee := int64(math.Ceil(float64(gas) / 40.0)) //the gas price is 0.025

client/client.go

@@ -54,7 +54,10 @@ func New(ctx context.Context, cfg Config, kr keyring.Keyring, opts ...Option) (*
 		Timeout:  cfg.StorageTimeout,
 	}, kr)
 	if err != nil {
-		blockchainClient.Close()
+		err = blockchainClient.Close()
+		if err != nil {
+			return nil, fmt.Errorf("cascade init failed: %v; also failed to close blockchain client: %w", err, err)
+		}
 		return nil, fmt.Errorf("failed to initialize cascade client: %w", err)
 	}
 

examples/cascade-download/main.go

@@ -57,7 +57,7 @@ func main() {
 	if err != nil {
 		log.Fatalf("Failed to create client: %v", err)
 	}
-	defer client.Close()
+	defer client.Close() //nolint:errcheck
 
 	fmt.Println("Downloading file...")
 	result, err := client.Cascade.Download(ctx, *actionID, *outputDir)

examples/cascade-upload/main.go

@@ -51,7 +51,7 @@ func main() {
 	if err != nil {
 		log.Fatalf("Failed to create client: %v", err)
 	}
-	defer client.Close()
+	defer client.Close() //nolint:errcheck
 
 	fmt.Println("Uploading file...")
 	opts := []cascade.UploadOption{cascade.WithPublic(*public)}

examples/claim-tokens/main.go

@@ -41,7 +41,7 @@ func main() {
 	if err != nil {
 		log.Fatalf("Failed to create client: %v", err)
 	}
-	defer client.Close()
+	defer client.Close() //nolint:errcheck
 
 	fmt.Println("Claim tokens example - to be implemented")
 	fmt.Println("This example will demonstrate claiming tokens from the old chain")

examples/query-actions/main.go

@@ -49,7 +49,7 @@ func main() {
 	if err != nil {
 		log.Fatalf("Failed to create client: %v", err)
 	}
-	defer client.Close()
+	defer client.Close() //nolint:errcheck
 
 	if id := strings.TrimSpace(*actionID); id != "" {
 		// Query a specific action

internal/utils/hash.go

@@ -7,7 +7,9 @@ import (
 // HashFile computes the Blake3 hash of a file
 func HashFile(data []byte) []byte {
 	hasher := blake3.New(32, nil)
-	hasher.Write(data)
+	_, err := hasher.Write(data)
+	if err != nil {
+		return nil
+	}
 	return hasher.Sum(nil)
 }
-