Skip to content

Use correct option for ApolloPlayerAttackEvent#256

Merged
ItsNature merged 1 commit into
version/1.2.4from
fix/incorrect-option-check
Mar 13, 2026
Merged

Use correct option for ApolloPlayerAttackEvent#256
ItsNature merged 1 commit into
version/1.2.4from
fix/incorrect-option-check

Conversation

@ItsNature

@ItsNature ItsNature commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator

Overview

Description:
Use the correct option for ApolloPlayerAttackEvent. Fixes a regression introduced in #248.


Review Request Checklist

  • Your code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have tested this change myself. (If applicable)
  • I have made corresponding changes to the documentation. (If applicable)
  • The branch name follows the projects naming conventions. (e.g. feature/add-module & bugfix/fix-issue)

@ItsNature ItsNature added the type: Bug Something is broken :( label Mar 11, 2026
@ItsNature
ItsNature merged commit 0291d37 into version/1.2.4 Mar 13, 2026
1 check passed
@ItsNature
ItsNature deleted the fix/incorrect-option-check branch March 17, 2026 00:41
@ItsNature ItsNature mentioned this pull request Mar 17, 2026
ItsNature added a commit that referenced this pull request Mar 27, 2026
* Deploy as 1.2.4-SNAPSHOT

* Feature - Crystal Optimizer (#257)

* Add `ServerRuleModule#CRYSTAL_OPTIMIZER` option

* Update version to 1.2.4

* Use correct option for `ApolloPlayerAttackEvent` (#256)

* example(team): prevent duplicate entries for the same player & improve team cleanup (#259)

* Improve analyitics error handling (#258)

* Silence UnknownHostException

* Don't send version request if `send-updater-message` is set to `false`

* Sync LunarClient Mods & Options (#262)

* Sync LunarClient Mods & Options

* Update version tags to 1.2.4

---------

Co-authored-by: LunarClient Bot <lc-bot@moonsworth.com>

* Bump to 1.2.4 (#263)

---------

Co-authored-by: LunarClient Bot <lc-bot@moonsworth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: Bug Something is broken :(

Development

Successfully merging this pull request may close these issues.

2 participants