Skip to content

Commit 2bf45bc

Browse files
Address CoPilot review
- ``_deferred_cases`` in ``_run_fixture_028``: dict[str, str] → set[str]. The case-level skip uses ``continue`` (not ``pytest.skip``) so the reason values had nowhere to surface; rationale stays in the per-block comment above the set. - ``_deferral.py`` docstring: drop the awkward escaped pluralization (``\\s`` rendered as a literal ``\s``) in favor of plain prose: "it executes ``continue`` inside an async loop".
1 parent 25f555e commit 2bf45bc

2 files changed

Lines changed: 9 additions & 10 deletions

File tree

tests/conformance/_deferral.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
1313
The case-level skip inside ``_run_fixture_028`` in
1414
``test_observability.py`` deliberately doesn't use this helper — it
15-
``continue``\\s inside an async loop iterating sub-cases of a single
16-
fixture rather than skipping the outer pytest test.
15+
executes ``continue`` inside an async loop iterating sub-cases of a
16+
single fixture rather than skipping the outer pytest test.
1717
"""
1818

1919
from __future__ import annotations

tests/conformance/test_observability.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -895,20 +895,19 @@ async def _run_fixture_028(spec: Mapping[str, Any]) -> None:
895895
# Case-level deferrals for fixture 028. The spec extends the
896896
# fixture with new negative-control cases as new reserved keys
897897
# land in §3.4; impl-side coverage for those cases lands in the
898-
# PR that implements the corresponding key reservation.
899-
_deferred_cases: dict[str, str] = {
898+
# PR that implements the corresponding key reservation. Stored as
899+
# a set since the skip is a ``continue`` (no ``pytest.skip``
900+
# reason surface); rationale lives in the per-block comment above
901+
# each name.
902+
_deferred_cases: set[str] = {
900903
# Proposal 0052 (implementation attribution, spec v0.44.0)
901904
# extends the reserved-set 24 → 26 names with
902905
# ``implementation_name`` / ``implementation_version``.
903906
# Coverage lands in PR 3 of the v0.12.0 cycle alongside the
904907
# ``openarmature.implementation.*`` invocation-span attribute
905908
# emission.
906-
"rejects_reserved_oa_name_implementation_name": (
907-
"Proposal 0052 implementation attribution; lands in PR 3 of v0.12.0"
908-
),
909-
"rejects_reserved_oa_name_implementation_version": (
910-
"Proposal 0052 implementation attribution; lands in PR 3 of v0.12.0"
911-
),
909+
"rejects_reserved_oa_name_implementation_name",
910+
"rejects_reserved_oa_name_implementation_version",
912911
}
913912
cases = cast("list[dict[str, Any]]", spec["cases"])
914913
for case in cases:

0 commit comments

Comments
 (0)