Commit 5e0d95a
committed
ci: release workflow's test job needs --all-extras
The release workflow's ``test`` job synced with bare
``uv sync --frozen``, which doesn't install optional
dependencies. The ``[otel]`` extras carry every OpenTelemetry
package the observability test suites import; without them
pyright sees ``Unknown`` for every OTel-typed expression in
``tests/conformance/test_observability.py`` and
``tests/unit/test_observability_otel.py`` and fails the
``Type check (pyright)`` step (633 errors against the v0.5.0-rc1
tag's first run).
CI's ``test`` job already syncs with ``--all-extras`` so the
package's main CI passes; the release workflow needs the same
flag for parity. Build job stays on bare ``uv sync --frozen`` —
``uv build`` reads ``pyproject.toml`` directly and emits the
wheel without consulting installed deps, so optional extras
don't affect the build artifact.
``pytest.importorskip("opentelemetry.sdk.trace")`` skips the
OTel test modules at collection time when the extras aren't
installed, but pyright doesn't honor that guard — it still
type-checks the file and surfaces every missing-stub
expression. ``--all-extras`` is the simplest fix.1 parent 94b51ea commit 5e0d95a
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
36 | 41 | | |
37 | | - | |
| 42 | + | |
38 | 43 | | |
39 | 44 | | |
40 | 45 | | |
| |||
0 commit comments