Commit 63de33e
committed
graph: phase 2 PR review fixes
Three real bugs surfaced by review:
- compiled.py: _step_subgraph_node now wraps raw exceptions escaping
the parent's middleware chain as NodeException with recoverable_state,
matching _step_function_node. Previously a middleware-raised exception
around a SubgraphNode dispatch escaped uncaught.
- test_pipeline_utilities.py: the determinism re-run path
(run_count > 1) now passes the clock stub when re-translating
middleware. Was dropping it, so a future fixture combining
determinism with TimingMiddleware would silently use real
time.monotonic on subsequent runs.
- test_pipeline_utilities.py: the subgraph middleware translation
path now also passes the clock stub. Same omission as the
determinism path — affects any future fixture combining a subgraph
with TimingMiddleware.
No current fixture exercises the latter two combinations; fix is
defensive so the harness faithfully translates fixture intent.1 parent 15c7298 commit 63de33e
2 files changed
Lines changed: 13 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
446 | | - | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
447 | 457 | | |
448 | 458 | | |
449 | 459 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
331 | 331 | | |
332 | 332 | | |
333 | 333 | | |
334 | | - | |
| 334 | + | |
335 | 335 | | |
336 | 336 | | |
337 | 337 | | |
| |||
382 | 382 | | |
383 | 383 | | |
384 | 384 | | |
385 | | - | |
| 385 | + | |
386 | 386 | | |
387 | 387 | | |
388 | 388 | | |
| |||
0 commit comments