Commit b583b0a
committed
Apply review fixes to tier-2a harness
Address review feedback on the tier-2a fixture wiring:
- _run_langfuse_trace_case wraps invoke/drain in try/finally so the
observer is always shut down, even if the graph raises.
- _run_invocation_id_case now holds the LangfuseObserver reference and
shuts it down in finally, matching the other Langfuse runners.
- _assert_langfuse_observation_tree enables the value-matcher only when
both bindings and params are provided (and, not or), so a partial call
degrades to exact match instead of half-enabling the matcher.1 parent 9a4e2b2 commit b583b0a
1 file changed
Lines changed: 9 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2753 | 2753 | | |
2754 | 2754 | | |
2755 | 2755 | | |
2756 | | - | |
2757 | | - | |
2758 | | - | |
| 2756 | + | |
| 2757 | + | |
| 2758 | + | |
| 2759 | + | |
| 2760 | + | |
2759 | 2761 | | |
2760 | 2762 | | |
2761 | 2763 | | |
| |||
2789 | 2791 | | |
2790 | 2792 | | |
2791 | 2793 | | |
2792 | | - | |
| 2794 | + | |
| 2795 | + | |
2793 | 2796 | | |
2794 | 2797 | | |
2795 | 2798 | | |
2796 | 2799 | | |
2797 | 2800 | | |
2798 | 2801 | | |
| 2802 | + | |
2799 | 2803 | | |
2800 | 2804 | | |
2801 | 2805 | | |
| |||
3768 | 3772 | | |
3769 | 3773 | | |
3770 | 3774 | | |
3771 | | - | |
| 3775 | + | |
3772 | 3776 | | |
3773 | 3777 | | |
3774 | 3778 | | |
| |||
0 commit comments