Skip to content

Commit c82d1f1

Browse files
Align conformance.toml note + visible 028 skip
From PR #95 review: - Rewrite the conformance.toml convention block to acknowledge that feature PRs which bump the spec submodule pin update this file too, setting `since` to the upcoming release version (matches the v0.10.0 cycle's pattern in PR #85 / #88, and how this PR works). - Emit warnings.warn for 028's deferred augment_metadata case so pytest's end-of-run summary surfaces the deferred coverage by name rather than silently passing.
1 parent e7ab886 commit c82d1f1

2 files changed

Lines changed: 17 additions & 5 deletions

File tree

conformance.toml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,13 @@
2222
# between pinned-spec and spec-head is the consumer's job (e.g., the
2323
# spec docs site computes the difference and renders accordingly).
2424
#
25-
# Convention: this file is only updated as part of release PRs. Between
26-
# releases, the manifest reflects the most-recently-published version
27-
# so external readers never see a `since` referring to an unreleased
28-
# pre-tag commit.
25+
# Convention: this file is updated as part of release PRs AND as part
26+
# of feature PRs that bump the spec submodule pin (the manifest guard
27+
# requires entries for every Accepted proposal in the pinned spec, so
28+
# a submodule bump forces this file to update too). Such bump PRs set
29+
# `since` to the upcoming release version; between the bump PR and the
30+
# matching tag, external readers will see a `since` referring to the
31+
# upcoming, unreleased version.
2932

3033
[manifest]
3134
implementation = "openarmature-python"

tests/conformance/test_observability.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -887,12 +887,21 @@ async def _run_fixture_028(spec: Mapping[str, Any]) -> None:
887887
# Cases using the `augment_metadata` directive exercise §3.4
888888
# mid-invocation rejection at set_invocation_metadata. The
889889
# augment_metadata harness primitive (per fixture 034) lands
890-
# with proposal 0040 / task #22; skip until then.
890+
# with proposal 0040 / task #22; surface the deferral via
891+
# warnings.warn so pytest's end-of-run summary lists it (rather
892+
# than silently passing) and continue to the other cases.
891893
nodes_check = cast("dict[str, Any]", case.get("nodes", {}))
892894
if any(
893895
isinstance(n, dict) and "augment_metadata" in cast("dict[str, Any]", n)
894896
for n in nodes_check.values()
895897
):
898+
import warnings # noqa: PLC0415
899+
900+
warnings.warn(
901+
f"028 case {case_name!r} deferred: augment_metadata harness primitive "
902+
f"lands with proposal 0040 / #22",
903+
stacklevel=2,
904+
)
896905
continue
897906
try:
898907
# Build a minimal graph from the case's nodes/edges. The

0 commit comments

Comments
 (0)