observability: PR #19 review followups + CI extras fix

Three changes:

- **CI** — ``uv sync --frozen`` didn't install the ``[otel]`` extras,
  so pyright type-checked ``tests/unit/test_observability_otel.py``
  against missing ``opentelemetry.*`` symbols and produced 373
  false-positive errors. Switched to ``--all-extras`` so every
  optional-dependency group is present in CI.
- **OTelObserver.spec_version factory** — ``default_factory=lambda:
  _read_spec_version()`` simplified to ``default_factory=_read_spec_version``;
  the lambda was a redundant wrapper.
- **test_correlation.py** — replaced ``lambda s: _pre(s)`` with the
  bare ``_pre``; the type-ignore came off too.

The other two unnecessary-lambda findings (``detached_subgraphs`` /
``detached_fan_outs`` factories) are kept with an explanatory comment
— pyright strict mode infers ``default_factory=frozenset`` as
``frozenset[Unknown]`` and flags it; the lambda preserves the
``frozenset[str]`` annotation.

Author: chris-colinsky

.github/workflows/ci.yml

@@ -36,7 +36,14 @@ jobs:
       # version developers run locally.
 
       - name: Sync deps
-        run: uv sync --frozen
+        # ``--all-extras`` installs every optional-dependency group
+        # (currently ``[otel]``) so pyright type-checks the
+        # OTel-using modules with real types and tests covering
+        # extras-gated code paths run end-to-end. Without this,
+        # ``opentelemetry.*`` symbols come back Unknown and pyright
+        # produces hundreds of false-positive errors on
+        # ``tests/unit/test_observability_otel.py``.
+        run: uv sync --frozen --all-extras
 
       - name: Lint (ruff check)
         run: uv run ruff check .

src/openarmature/observability/otel/observer.py

@@ -114,14 +114,19 @@ class OTelObserver:
     """
 
     span_processor: SpanProcessor
+    # Lambda-wrapped factories give pyright the explicit
+    # ``frozenset[str]`` type — ``default_factory=frozenset``
+    # alone produces ``frozenset[Unknown]`` which the strict-mode
+    # config flags. The lambda overhead is negligible (one closure
+    # call per dataclass instance).
     detached_subgraphs: frozenset[str] = field(default_factory=lambda: frozenset[str]())
     detached_fan_outs: frozenset[str] = field(default_factory=lambda: frozenset[str]())
     disable_llm_spans: bool = False
     # Read from the package's ``__spec_version__`` (one of the three
     # places the spec version is pinned per CLAUDE.md). Bumping the
     # spec submodule + the two version fields automatically updates
     # the value reported on every invocation span.
-    spec_version: str = field(default_factory=lambda: _read_spec_version())
+    spec_version: str = field(default_factory=_read_spec_version)
 
     # Internal state, populated in __post_init__ and during invocation.
     _provider: TracerProvider = field(init=False, repr=False)

tests/unit/test_correlation.py

@@ -156,7 +156,7 @@ async def maybe_fail(_s: _ResumeState) -> dict[str, str | bool]:
     # a ``pre`` node whose successful save arms the resume.
     pre = (
         GraphBuilder(_ResumeState)
-        .add_node("pre", lambda s: _pre(s))  # type: ignore[arg-type,return-value]
+        .add_node("pre", _pre)
         .add_node("a", maybe_fail)
         .add_edge("pre", "a")
         .add_edge("a", END)