Commit e7cb0de
committed
fix(examples): hello-world base_url default and observer trace
Two bugs surfaced during live validation against OpenAI:
- The default LLM_BASE_URL was https://api.openai.com/v1, but our
OpenAIProvider's wire path posts to /v1/chat/completions itself.
httpx URL join produced https://api.openai.com/v1/v1/chat/completions
→ 404. Convention is base_url = host root; impl adds /v1. Default
now matches; doc-string + README comment make it explicit.
- The observer trace fired on the OpenAIProvider LLM-span event
(sentinel namespace, post_state=None) and crashed accessing .sources.
Added a post_state is not None guard.1 parent 2d39a56 commit e7cb0de
2 files changed
Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
| 116 | + | |
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
67 | 69 | | |
68 | 70 | | |
69 | 71 | | |
70 | | - | |
| 72 | + | |
71 | 73 | | |
72 | 74 | | |
73 | 75 | | |
| |||
103 | 105 | | |
104 | 106 | | |
105 | 107 | | |
106 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
107 | 112 | | |
108 | 113 | | |
109 | 114 | | |
| |||
0 commit comments