Skip to content

Commit f5730d9

Browse files
Fix stale comment refs in fixture 037 activation
PR #101 review caught two comment inaccuracies in the fixture 037 activation block: - The block-level comment at line 84 referenced `_DEFERRED_037_CASES`, but the symbol was renamed to the generic `_DEFERRED_CASES` during drafting (other fixtures may want per-case deferrals later). - The block-level comment at line 108 described the deferral mechanism as `pytest.skip`, but the runner uses `continue` — matching the inline comment at the skip site, which correctly explains that `pytest.skip` would mask the surrounding cases that DO run. Comment-only diff; no behavior change.
1 parent 295737a commit f5730d9

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

tests/conformance/test_observability_langfuse.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
# deferred to a follow-up PR — it needs the langfuse harness to
8282
# grow checkpointer wiring + flaky-node test seam + two-phase
8383
# multi-trace assertion. Listed individually in
84-
# ``_DEFERRED_037_CASES`` rather than at the fixture level so the
84+
# ``_DEFERRED_CASES`` rather than at the fixture level so the
8585
# four other cases run.
8686
"037-langfuse-trace-input-output",
8787
# 029 + 030 stay deferred in v0.11.0:
@@ -106,11 +106,12 @@
106106

107107

108108
# Per-case deferrals within an otherwise-activated fixture. Each entry is
109-
# ``(fixture_stem, case_name)``. The case-loop in the runner skips matching
110-
# cases with a clear pytest.skip reason. Used for proposal-0043 case 5
111-
# (resume re-fire) which needs harness extensions tracked separately —
112-
# checkpointer wiring + flaky-node test seam + two-phase multi-trace
113-
# assertion — landed in a follow-up PR.
109+
# ``(fixture_stem, case_name)``. The case-loop in the runner ``continue``s
110+
# past matching cases — NOT ``pytest.skip``, which would skip the whole
111+
# fixture's test invocation and hide the surrounding cases that DO run.
112+
# Used for proposal-0043 case 5 (resume re-fire) which needs harness
113+
# extensions tracked separately — checkpointer wiring + flaky-node test
114+
# seam + two-phase multi-trace assertion — landed in a follow-up PR.
114115
_DEFERRED_CASES: frozenset[tuple[str, str]] = frozenset(
115116
{
116117
(

0 commit comments

Comments
 (0)