Commit fceaa9f
authored
Guard _assert_error_span_extras against duplicate span names (#231)
Address CoPilot review on #230 (the guard landed after the squash-merge).
_assert_error_span_extras picked candidates[0] for a span name; with a
single-attempt fixture (124) names are unique, but a future fixture with
multiple same-named spans (e.g. call-level retry) could silently assert
the wrong span. Assert exactly one candidate so that case fails loudly
here instead, rather than duplicating _assert_span_tree_matches's full
name+attribute disambiguation.
Test-only; no behavior change.1 parent 338e4b8 commit fceaa9f
1 file changed
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3906 | 3906 | | |
3907 | 3907 | | |
3908 | 3908 | | |
| 3909 | + | |
| 3910 | + | |
| 3911 | + | |
| 3912 | + | |
| 3913 | + | |
3909 | 3914 | | |
3910 | 3915 | | |
3911 | 3916 | | |
| |||
0 commit comments