Update stale 'four patterns' docstring in test#123
Merged
Conversation
The pattern catalog grew from 4 to 7 entries during the v0.11.0 cycle (state-migration-on-resume, caller-supplied-trace-identifiers, observer-state-reconciliation all landed). The test_get_returns_distinct_content_per_pattern docstring + comment still referred to 'four patterns' / 'four slugs' / 'All four contents'. The assertion is count-agnostic (uses patterns.list() length); only the prose needs updating. Surfaced by CoPilot review on main.
There was a problem hiding this comment.
Pull request overview
Updates stale prose in test_get_returns_distinct_content_per_pattern to reflect that the patterns catalog has grown beyond four entries, without changing test behavior.
Changes:
- Adjusted the test docstring to remove “four patterns” wording and describe “multiple slugs” instead.
- Updated the inline comment to say “All contents are unique.”
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The patterns catalog grew from 4 to 7 entries during the v0.11.0 cycle (state-migration-on-resume, caller-supplied-trace-identifiers, observer-state-reconciliation all landed). The
test_get_returns_distinct_content_per_patterndocstring + comment still referenced "four patterns" / "four slugs" / "All four contents". The assertion itself is count-agnostic (usespatterns.list()length); only the prose needed updating.Surfaced by CoPilot review on main.
Test plan
uv run pytest tests/unit/test_patterns_api.py -v— all 7 tests pass including the renamed one