Skip to content

Guard _assert_error_span_extras against duplicate span names #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chris-colinsky merged 1 commit into from
Jul 23, 2026
Merged

Guard _assert_error_span_extras against duplicate span names #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/conformance/test_observability.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3906,6 +3906,11 @@ def _walk(entries: list[dict[str, Any]]) -> None:
name = cast("str", entry["name"])
candidates = by_name.get(name, [])
assert candidates, f"expected a span named {name!r}; got {sorted(by_name)}"
assert len(candidates) == 1, (
f"_assert_error_span_extras assumes unique span names; {name!r} matched "
f"{len(candidates)}. Add name+attribute disambiguation if a fixture emits "
f"multiple same-named spans (e.g. call-level retry)."
)
span = candidates[0]
desc = entry.get("status_description")
if desc is not None:
Expand Down