Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/codeql/codeql-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,23 @@ query-filters:
# the CodeQL rule doesn't lose signal.
- exclude:
id: py/unsafe-cyclic-import
# ``py/cyclic-import`` is the broader sibling of
# ``py/unsafe-cyclic-import`` (above) and fires on the same
# false-positive class: TYPE_CHECKING-gated typed-module cycles
# that do not exist at runtime. The current instances are the
# ``graph`` <-> ``observability`` typing boundary:
#
# - ``observability/correlation.py``, ``observability/tool_call.py``,
# and ``observability/metadata.py`` import graph event/observer
# types only inside ``if TYPE_CHECKING:`` blocks (with
# ``from __future__ import annotations``), while ``graph/events.py``
# imports the ``AttributeValue`` type alias from
# ``observability.metadata`` at runtime. The back-edges never
# execute, so ``import openarmature.graph.events`` resolves with
# no runtime cycle (verified).
#
# As with ``py/unsafe-cyclic-import``, pyright's
# ``reportImportCycles`` covers the genuine runtime-cycle cases at
# type-check time, so dropping the CodeQL rule doesn't lose signal.
- exclude:
id: py/cyclic-import