Change in has_external_format

External images which during capture have been dumped as
VK_FORMAT_R8G8B8A8_UNORM, during replay can be treated as normal images

Author: panos-lunarg

framework/decode/vulkan_replay_consumer_base.cpp

@@ -6322,6 +6322,7 @@ VulkanReplayConsumerBase::OverrideCreateImage(PFN_vkCreateImage
             // In this case, the image has been sampled at capture time and format is now RGBA8_UNORM.
             modified_create_info.format     = VK_FORMAT_R8G8B8A8_UNORM;
             external_format->externalFormat = 0;
+            has_external_format             = false;
         }
 
         if (external_memory->handleTypes & VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD_BIT)

framework/encode/vulkan_capture_manager.cpp

@@ -2315,7 +2315,6 @@ void VulkanCaptureManager::ProcessImportFdForImage(VkDevice device, VkImage imag
         image_resource.external_format      = image_wrapper->external_format;
         image_resource.size                 = image_wrapper->size;
         image_resource.aspect               = aspect;
-        image_resource.external_format      = image_wrapper->external_format;
         image_resource.all_layers_per_level = true;
 
         num_staging_bytes += image_wrapper->size;

framework/encode/vulkan_state_writer.cpp

@@ -2752,7 +2752,6 @@ void VulkanStateWriter::ProcessImageMemoryWithAssetFile(const vulkan_wrappers::D
             image_resource.sample_count                                 = image_wrapper->samples;
             image_resource.layout                                       = image_wrapper->current_layout;
             image_resource.queue_family_index                           = image_wrapper->queue_family_index;
-            image_resource.external_format                              = image_wrapper->external_format;
             image_resource.size                                         = image_wrapper->size;
             image_resource.resource_size                                = snapshot_entry.resource_size;
             image_resource.level_sizes                                  = &snapshot_entry.level_sizes;