make WIN32 into _WIN32#3028
Merged
bradgrantham-lunarg merged 2 commits intoJul 10, 2026
Merged
Conversation
bradgrantham-lunarg
added
the
approved-to-run-ci
ncesario-lunarg
approved these changes
Jun 17, 2026
ncesario-lunarg
left a comment
ncesario-lunarg
left a comment
Contributor
There was a problem hiding this comment.
One nit, but LGTM!
| #include "util/defines.h" | ||
|
|
||
| #ifdef WIN32 | ||
| #ifdef _WIN32 |
Contributor
There was a problem hiding this comment.
Suggested change
| #ifdef _WIN32 | |
| #if defined(_WIN32) |
General comment for other occurrences. Based on your recommendation offline.
MarkY-LunarG
approved these changes
Jun 23, 2026
MarkY-LunarG
left a comment
MarkY-LunarG
left a comment
Contributor
There was a problem hiding this comment.
I don't share Nate's nit, but it's up to you.
bradgrantham-lunarg
force-pushed
the
brad-win32-macro
branch
from
b912b71 to
9374584
Compare
bradgrantham-lunarg
requested review from
charles-lunarg,
davidd-lunarg,
fabian-lunarg,
jzulauf-lunarg,
mikes-lunarg and
panos-lunarg
as code owners
bradgrantham-lunarg
force-pushed
the
brad-win32-macro
branch
from
9374584 to
ed520fa
Compare
Contributor
Author
|
Let's see if I can merge after any one of the CODEOWNERS approves. |
davidd-lunarg
approved these changes
Jul 8, 2026
charles-lunarg
approved these changes
Jul 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.