replay / virtual swapchain: Fix two VVL issues#3066
Merged
fabian-lunarg merged 3 commits intoJul 9, 2026
Conversation
fabian-lunarg
force-pushed
the
fabian_swapchain_vvl_issues
branch
from
July 6, 2026 12:10
0d6adc3 to
65f4ff1
Compare
panos-lunarg
reviewed
Jul 7, 2026
panos-lunarg
approved these changes
Jul 7, 2026
panos-lunarg
left a comment
Contributor
There was a problem hiding this comment.
Apart from a minor comment looks good
- initial transition removed, per-image transition on first acquire - wait + re-signal acquire semaphore, or wait acquire fence - gate on acquire success, keep VK_SUBOPTIMAL_KHR - drop unused deferred_alloc - fix copy_queue_family_index_ for graphics-queue path
…tate load - implement ProcessSetSwapchainImageStateCommand (was empty stub) - transition virtual images UNDEFINED -> captured layout in one injected submit - skip UNDEFINED entries and unrecognized image IDs - fixes VUID-vkCmdDraw-None-09600 on first use after trim load
… vulkan_temporary_objects.h/.cpp - add CreateAndBegin(queue_family_index) overload - use GetDeviceQueue2-aware queue retrieval, check EndCommandBuffer/QueueSubmit results - use TemporaryCommandBuffer in ProcessSetSwapchainImageStateCommand
fabian-lunarg
force-pushed
the
fabian_swapchain_vvl_issues
branch
from
July 7, 2026 16:42
65f4ff1 to
074cb2f
Compare
fabian-lunarg
enabled auto-merge
July 7, 2026 16:50
panos-lunarg
reviewed
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when replaying a capture using VVL via the
--validateoption I'm seeing issues that are not presentin the captured application.
per swapchain-image (3x in my case)
and in addition for trimmed captures, also multiple times:
both errors are coming from our virtual swapchain and are fixed in this PR.