MITM DNS false (I hope) report?

[ArtOfCombat]

My Antivirus reported a MITM DNS hijack in your code. I hope you are not doing this intentionally, and if you aren't, please check why it might be falsely reported.

[bspkrs]

Was it LunatriusCore specifically that produced the report? Which antivirus vendor, software, and version? Can you provide the specific details of the virus report?

[ArtOfCombat]

I will shortly - it was LC. It was in Avast, will get version too.

[Lunatrius]

Turn off update checking in the settings. I have added invisible updates for the meanwhile mentioning this. I've been trying around to get the mods updated but I haven't really found enough time to start migrating the mods.

[Lunatrius]

Turns out that the nameserver domain expired for the web server where I'm hosting my stuff. I've fixed up the DNS records and it should not happen anymore.

With all that said, everyone should still turn off update checks. I'm not sure when/if I'll be able to update my mods, so there is no point in having the mod check for updates.

In hindsight, I should've added some sort of "kill switch", to automatically turn off update checks for old/outdated versions.

[Lunatrius]

tl;dr: the worst thing that could have happened, would be the MITM AV warning, the client side does does not execute anything that is fetched from the server (the /json endpoint)