Skip to content

Change submodule URL to use HTTPS#673

Open
VeryUsual wants to merge 1 commit into
LuteOrg:developfrom
VeryUsual:patch-2
Open

Change submodule URL to use HTTPS#673
VeryUsual wants to merge 1 commit into
LuteOrg:developfrom
VeryUsual:patch-2

Conversation

@VeryUsual

Copy link
Copy Markdown
Contributor

Change submodule URL to use HTTPS to ensure easier access for all contributors in areas where SSH keys may not be available

…tributors in areas where SSH keys may not be available
@VeryUsual
VeryUsual changed the base branch from master to develop April 19, 2026 22:08
@jzohrab jzohrab self-assigned this Apr 20, 2026
@jzohrab jzohrab added this to Lute-v3 Apr 20, 2026
@jzohrab jzohrab moved this to In Progress in Lute-v3 Apr 20, 2026
@jzohrab

jzohrab commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

Thank you @VeryUsual . I've never bothered to look into the difference between these, but it does look like https is better for a casual, open team. Anki uses https as well in their repo (ref https://github.com/ankitects/anki/blob/main/.gitmodules). Devs can override that to ssh if they want -- git config submodule.<name>.url git@github.com:org/repo.git

I don't see why the tests failed, I'll rerun the job.

I'll also try out another local clone to see what cred prompts or anything I get, b/c that would need to be documented for new devs.

@jzohrab

jzohrab commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

Hm repeated failures, though the submodule checkout succeeded in CI. Not sure why, will try running the dev line in CI again.

@jzohrab

jzohrab commented Apr 26, 2026

Copy link
Copy Markdown
Collaborator

Continues to die after repeat reruns. I'll have to try this locally to see if I can sort out what's up, as this doesn't make sense that it would fail after a successful checkout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants