Drop legacy id (#3375)

Author: ildyria

app/Constants/RandomID.php

@@ -27,6 +27,4 @@ class RandomID
 	 */
 	public const ID_LENGTH = 24;
 	public const ID_TYPE = 'string';
-	public const LEGACY_ID_NAME = 'legacy_id';
-	public const LEGACY_ID_TYPE = 'integer';
 }

app/Exceptions/Handler.php

@@ -14,7 +14,6 @@
 use App\Exceptions\Handlers\AccessDBDenied;
 use App\Exceptions\Handlers\AdminSetterHandler;
 use App\Exceptions\Handlers\InstallationHandler;
-use App\Exceptions\Handlers\LegacyIdExceptionHandler;
 use App\Exceptions\Handlers\MigrationHandler;
 use App\Exceptions\Handlers\NoEncryptionKey;
 use App\Exceptions\Handlers\ViteManifestNotFoundHandler;
@@ -115,7 +114,6 @@ class Handler extends ExceptionHandler
 		AdminSetterHandler::class,
 		MigrationHandler::class,
 		ViteManifestNotFoundHandler::class,
-		LegacyIdExceptionHandler::class,
 	];
 
 	/** @var array<int,class-string<\Throwable>> */

app/Exceptions/Handlers/LegacyIdExceptionHandler.php

@@ -97,7 +97,6 @@
  * implementation of it) and we need this class to be instantiable.
  *
  * @property string                           $id
- * @property int                              $legacy_id
  * @property Carbon                           $created_at
  * @property Carbon                           $updated_at
  * @property string                           $title
@@ -176,7 +175,6 @@ class BaseAlbumImpl extends Model implements HasRandomID
 	 */
 	protected $attributes = [
 		'id' => null,
-		RandomID::LEGACY_ID_NAME => null,
 		'created_at' => null,
 		'updated_at' => null,
 		'title' => null, // Sic! `title` is actually non-nullable, but using `null` here forces the caller to actually set a title before saving.
@@ -196,7 +194,6 @@ class BaseAlbumImpl extends Model implements HasRandomID
 	 */
 	protected $casts = [
 		'id' => RandomID::ID_TYPE,
-		RandomID::LEGACY_ID_NAME => RandomID::LEGACY_ID_TYPE,
 		'created_at' => 'datetime',
 		'updated_at' => 'datetime',
 		'is_nsfw' => 'boolean',

app/Models/BaseAlbumImpl.php

@@ -36,7 +36,6 @@
  *
  * @property string                           $id
  * @property string                           $title
- * @property int                              $legacy_id
  * @property Carbon                           $created_at
  * @property Carbon                           $updated_at
  * @property string|null                      $description

app/Models/Extensions/BaseAlbum.php

@@ -12,7 +12,6 @@
 use App\Exceptions\InsufficientEntropyException;
 use App\Exceptions\Internal\NotImplementedException;
 use App\Exceptions\Internal\TimeBasedIdException;
-use App\Models\Configs;
 use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\InvalidCastException;
 use Illuminate\Database\Eloquent\JsonEncodingException;
@@ -64,9 +63,6 @@ public function setAttribute($key, $value): mixed
 		if ($key === $this->getKeyName()) {
 			throw new NotImplementedException('must not set primary key explicitly, primary key will be set on first insert');
 		}
-		if ($key === RandomID::LEGACY_ID_NAME) {
-			throw new NotImplementedException('must not set legacy key explicitly, legacy key will be set on first insert');
-		}
 
 		return parent::setAttribute($key, $value);
 	}
@@ -170,27 +166,6 @@ private function generateKey(): void
 		} catch (\Exception $e) {
 			throw new InsufficientEntropyException($e);
 		}
-		// @codeCoverageIgnoreEnd
-		if (
-			PHP_INT_MAX === 2147483647 ||
-			Configs::getValueAsBool('force_32bit_ids')
-		) {
-			// For 32-bit installations, we can only afford to store the
-			// full seconds in id.  The calling code needs to be able to
-			// handle duplicate ids.  Note that this also exposes us to
-			// the year 2038 problem.
-			// @codeCoverageIgnoreStart
-			$legacy_id = sprintf('%010d', microtime(true));
-		// @codeCoverageIgnoreEnd
-		} else {
-			// Ensure 4 digits after the decimal point, 15 characters
-			// total (including the decimal point), 0-padded on the
-			// left if needed (shouldn't be needed unless we move back in
-			// time :-) )
-			$legacy_id = sprintf('%015.4f', microtime(true));
-			$legacy_id = str_replace('.', '', $legacy_id);
-		}
 		$this->attributes[$this->getKeyName()] = $id;
-		$this->attributes[RandomID::LEGACY_ID_NAME] = intval($legacy_id);
 	}
 }

app/Models/Extensions/HasRandomIDAndLegacyTimeBasedID.php

@@ -12,7 +12,6 @@
 use App\Casts\ArrayCast;
 use App\Casts\DateTimeWithTimezoneCast;
 use App\Casts\MustNotSetCast;
-use App\Constants\RandomID;
 use App\Contracts\Models\HasUTCBasedTimes;
 use App\Enum\LicenseType;
 use App\Enum\StorageDiskType;
@@ -43,7 +42,6 @@
  * App\Models\Photo.
  *
  * @property string       $id
- * @property int          $legacy_id
  * @property string       $title
  * @property string|null  $description
  * @property string[]     $tags
@@ -151,7 +149,6 @@ class Photo extends Model implements HasUTCBasedTimes
 	public $incrementing = false;
 
 	protected $casts = [
-		RandomID::LEGACY_ID_NAME => RandomID::LEGACY_ID_TYPE,
 		'created_at' => 'datetime',
 		'updated_at' => 'datetime',
 		'taken_at' => DateTimeWithTimezoneCast::class,
@@ -172,7 +169,6 @@ class Photo extends Model implements HasUTCBasedTimes
 	 *                   relation but shall not be serialized to JSON
 	 */
 	protected $hidden = [
-		RandomID::LEGACY_ID_NAME,
 		'album',  // do not serialize relation in order to avoid infinite loops
 		'owner',  // do not serialize relation
 		'owner_id',

app/Models/Photo.php

@@ -0,0 +1,70 @@
+<?php
+
+/**
+ * SPDX-License-Identifier: MIT
+ * Copyright (c) 2017-2018 Tobias Reich
+ * Copyright (c) 2018-2025 LycheeOrg.
+ */
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+
+return new class() extends Migration {
+	public const LEGACY_ID_NAME = 'legacy_id';
+
+	/**
+	 * Run the migrations.
+	 */
+	public function up(): void
+	{
+		try {
+			Schema::table('photos', function (Blueprint $table) {
+				$table->dropUnique('photos_legacy_id_unique');
+			});
+			Schema::table('base_albums', function (Blueprint $table) {
+				$table->dropUnique('base_albums_legacy_id_unique');
+			});
+		} catch (\Throwable $e) {
+			// Do nothing
+		}
+
+		Schema::table('photos', function (Blueprint $table) {
+			$table->dropColumn(self::LEGACY_ID_NAME);
+		});
+		Schema::table('base_albums', function (Blueprint $table) {
+			$table->dropColumn(self::LEGACY_ID_NAME);
+		});
+
+		DB::table('configs')
+			->where('key', '=', 'legacy_id_redirection')
+			->delete();
+	}
+
+	/**
+	 * Reverse the migrations.
+	 */
+	public function down(): void
+	{
+		Schema::table('base_albums', function (Blueprint $table) {
+			$table->unsignedBigInteger('legacy_id')->after('id')->nullable(false);
+		});
+
+		Schema::table('photos', function (Blueprint $table) {
+			$table->unsignedBigInteger('legacy_id')->after('id')->nullable(false);
+		});
+
+		DB::table('configs')
+			->insert([
+				'key' => 'legacy_id_redirection',
+				'value' => '1',
+				'cat' => 'Admin',
+				'type_range' => '0|1',
+				'is_secret' => 0,
+				'description' => 'Enables/disables the redirection support for legacy IDs',
+				'level' => 0,
+				'not_on_docker' => 0,
+				'is_expert' => 1,
+				'order' => 6,
+			]);
+	}
+};