remove annoying check (#3517)

Author: ildyria

app/Actions/Diagnostics/Pipes/Checks/BasicPermissionCheck.php

@@ -12,6 +12,7 @@
 use App\Contracts\DiagnosticPipe;
 use App\DTO\DiagnosticData;
 use App\Enum\StorageDiskType;
+use App\Exceptions\ConfigurationKeyMissingException;
 use App\Exceptions\Handler;
 use App\Exceptions\Internal\InvalidConfigOption;
 use App\Facades\Helpers;
@@ -169,9 +170,15 @@ public function userCSS(array &$data): void
 			}
 			// @codeCoverageIgnoreEnd
 		}
-		if (Configs::getValueAsBool('disable_recursive_permission_check')) {
-			$data[] = DiagnosticData::info('Full directory permission check is disabled', self::class);
+		try {
+			if (Configs::getValueAsBool('disable_recursive_permission_check')) {
+				$data[] = DiagnosticData::info('Full directory permission check is disabled', self::class);
+			}
+			// @codeCoverageIgnoreStart
+		} catch (ConfigurationKeyMissingException) {
+			// we do nothing. Silently catch and ignore.
 		}
+		// @codeCoverageIgnoreEnd
 	}
 
 	/**
@@ -260,9 +267,15 @@ private function checkDirectoryPermissionsRecursively(string $path, array &$data
 			}
 
 			$dir = new \DirectoryIterator($path);
-			if (Configs::getValueAsBool('disable_recursive_permission_check')) {
+			try {
+				if (Configs::getValueAsBool('disable_recursive_permission_check')) {
+					return;
+				}
+			} catch (ConfigurationKeyMissingException) {
+				// We skip the check, we can come back later when the config value is available.
 				return;
 			}
+
 			// @codeCoverageIgnoreStart
 			foreach ($dir as $dir_entry) {
 				if ($dir_entry->isDir() && !$dir_entry->isDot()) {

app/Actions/InstallUpdate/ApplyUpdate.php

@@ -8,7 +8,6 @@
 
 namespace App\Actions\InstallUpdate;
 
-use App\Actions\InstallUpdate\Pipes\AllowMigrationCheck;
 use App\Actions\InstallUpdate\Pipes\ArtisanMigrate;
 use App\Actions\InstallUpdate\Pipes\BranchCheck;
 use App\Actions\InstallUpdate\Pipes\ComposerCall;
@@ -23,7 +22,6 @@ class ApplyUpdate
 	 */
 	private array $pipes = [
 		BranchCheck::class,
-		AllowMigrationCheck::class,
 		GitPull::class,
 		ArtisanMigrate::class,
 		ComposerCall::class,

app/Actions/InstallUpdate/Pipes/AllowMigrationCheck.php

@@ -0,0 +1,30 @@
+<?php
+
+/**
+ * SPDX-License-Identifier: MIT
+ * Copyright (c) 2017-2018 Tobias Reich
+ * Copyright (c) 2018-2025 LycheeOrg.
+ */
+
+use App\Models\Extensions\BaseConfigMigrationReversed;
+
+return new class() extends BaseConfigMigrationReversed {
+	public function getConfigs(): array
+	{
+		return [
+			[
+				'key' => 'force_migration_in_production',
+				'value' => '0',
+				'cat' => 'Admin',
+				'type_range' => self::BOOL,
+				'description' => 'Force migration even if app is in production mode',
+				'details' => '',
+				'is_secret' => false,
+				'level' => 0,
+				'order' => 4,
+				'not_on_docker' => true,
+				'is_expert' => true,
+			],
+		];
+	}
+};