Improve animation when switching images#3354
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
tinohager
approved these changes
May 22, 2025
JasonMillward
approved these changes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add visual feedback that we are going to the previous or next photos.
As we now have a nice transition, the shutter is no longer necessary.
Documentation on the transition component: https://vuejs.org/guide/built-ins/transition
This pull request introduces a new photo transition animation feature for the gallery photo viewer, enhancing the user experience with smooth sliding effects. It includes changes to support customizable transitions between photos and updates to the components and composables for managing these transitions.
Transition Animation Feature:
slide-nextandslide-previous) in thePhotoPanelcomponent. This includes adding atransitionprop, aTransitionwrapper, and corresponding CSS styles for smooth sliding effects. ([[1]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-97c3c69aa176ee33f02063b98b9fb29ecb07e27c76d3b8b058dca16bcc4ed327L2-R10),[[2]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-97c3c69aa176ee33f02063b98b9fb29ecb07e27c76d3b8b058dca16bcc4ed327R100-R101),[[3]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-97c3c69aa176ee33f02063b98b9fb29ecb07e27c76d3b8b058dca16bcc4ed327R149),[[4]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-97c3c69aa176ee33f02063b98b9fb29ecb07e27c76d3b8b058dca16bcc4ed327R165),[[5]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-97c3c69aa176ee33f02063b98b9fb29ecb07e27c76d3b8b058dca16bcc4ed327R238-R279))Updates to Composables:
useAlbumRefresherto include atransitionreactive variable and asetTransitionmethod to determine the direction of the slide based on the next or previous photo. ([[1]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-24ffd824e902635c5157c492b21f48a1031a3385c37e3fa44a7af8b5d91d0865R16),[[2]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-24ffd824e902635c5157c492b21f48a1031a3385c37e3fa44a7af8b5d91d0865R76-R87),[[3]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-24ffd824e902635c5157c492b21f48a1031a3385c37e3fa44a7af8b5d91d0865R98-R105))Integration with Views:
Album.vueandSearch.vueviews to pass thetransitionprop to thePhotoPanelcomponent and use thesetTransitionmethod when navigating between photos. ([[1]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-88a848123a6b43d2f9695bb217b0d435421b52774f19ea9cc79388f46de23c3cR38),[[2]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-88a848123a6b43d2f9695bb217b0d435421b52774f19ea9cc79388f46de23c3cL218-R219),[[3]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-88a848123a6b43d2f9695bb217b0d435421b52774f19ea9cc79388f46de23c3cR428-R429),[[4]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-e5023252e2c9afc91608da26a88b70b3e5dc53aba16bd66087a86d3e52e409a9R53),[[5]](https://github.com/LycheeOrg/Lychee/pull/3354/files#diff-e5023252e2c9afc91608da26a88b70b3e5dc53aba16bd66087a86d3e52e409a9R451-R452))