Refactoring LiveMetrics to avoid photo.album_id requirement.

[ildyria]

This pull request introduces significant changes to the metrics and event handling system, alongside updates to request handling for improved flexibility and consistency. Key changes include the creation of base classes for metrics events, the addition of a from_id attribute for better tracking, and refactoring of query logic in metrics retrieval.

Event System Refactoring:

• Introduced BaseAlbumMetricsEvent and BasePhotoMetricsEvent classes to centralize shared logic for album and photo-related metrics events, such as the key() method and toArray() method. [1] [2]
• Updated existing event classes (AlbumDownload, AlbumShared, AlbumVisit, PhotoDownload, PhotoFavourite, PhotoShared, PhotoVisit) to extend the new base classes, removing redundant key() method implementations. [1] [2] [3] [4] [5] [6] [7]

Request Handling Enhancements:

• Added a new HasFromId interface and HasFromIdTrait to standardize the handling of a from_id attribute in requests. [1] [2]
• Updated ZipRequest and PhotoMetricsRequest to implement HasFromId, enabling the use of from_id for additional context in metrics-related operations. [1] [2]

Metrics Query Optimization:

• Improved query logic in GetMetrics.php by adding a safeguard to exclude null album_id values and simplifying conditions for visit actions.
• Removed unused commented-out code in the select clause for cleaner and more maintainable queries.

Controller Updates:

• Updated controllers to include from_id in event dispatch calls, ensuring that this additional context is passed to metrics events. [1] [2] [3] [4]

Miscellaneous:

• Simplified the logic in LiveMetricsResource by removing fallback logic for album_id and photo URLs, assuming data consistency.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.03%. Comparing base (e813c38) to head (9e97597).

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.