Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
tinohager
approved these changes
May 22, 2025
JasonMillward
approved these changes
May 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On desktop:

On mobile:

This pull request introduces changes to the authentication flow and login functionality, including the creation of a dedicated login page, improvements to the login modal, and updates to routing and navigation. The key changes are grouped below by theme.
Authentication Flow Enhancements:
LoginFormcomponent (resources/js/components/forms/auth/LoginForm.vue) to encapsulate the login form logic and UI. This includes support for WebAuthn, OAuth providers, and error handling for invalid credentials.LoginModalwith the newLoginFormcomponent, simplifying the modal's structure.Routing and Navigation Updates:
LoginPagecomponent (resources/js/views/LoginPage.vue) to serve as a standalone login page, with a back button for navigation and integration with theLoginFormcomponent./loginroute pointing to theLoginPagecomponent. [1] [2]resources/js/menus/LeftMenu.vue) to navigate to the/loginroute instead of opening the login modal when the user is not logged in.Album Refresher Logic:
useAlbumsRefreshercomposable to redirect unauthenticated users to the/loginpage if no albums are available. This replaces the previous behavior of opening the login modal. [1] [2]routerinstance into theuseAlbumsRefreshercomposable and updated its usage in theAlbumsview. [1] [2]Backend Updates:
/loginroute to the backend (routes/web_v2.php) to serve the new login page.