Skip to content

Add login page instead of modal#3366

Merged
ildyria merged 3 commits intomasterfrom
login-page
May 25, 2025
Merged

Add login page instead of modal#3366
ildyria merged 3 commits intomasterfrom
login-page

Conversation

@ildyria
Copy link
Copy Markdown
Member

@ildyria ildyria commented May 21, 2025

On desktop:
image

On mobile:
image

This pull request introduces changes to the authentication flow and login functionality, including the creation of a dedicated login page, improvements to the login modal, and updates to routing and navigation. The key changes are grouped below by theme.

Authentication Flow Enhancements:

  • Created a new LoginForm component (resources/js/components/forms/auth/LoginForm.vue) to encapsulate the login form logic and UI. This includes support for WebAuthn, OAuth providers, and error handling for invalid credentials.
  • Replaced the inline login form in LoginModal with the new LoginForm component, simplifying the modal's structure.

Routing and Navigation Updates:

  • Added a new LoginPage component (resources/js/views/LoginPage.vue) to serve as a standalone login page, with a back button for navigation and integration with the LoginForm component.
  • Updated the router configuration to include a /login route pointing to the LoginPage component. [1] [2]
  • Modified the left menu (resources/js/menus/LeftMenu.vue) to navigate to the /login route instead of opening the login modal when the user is not logged in.

Album Refresher Logic:

  • Updated the useAlbumsRefresher composable to redirect unauthenticated users to the /login page if no albums are available. This replaces the previous behavior of opening the login modal. [1] [2]
  • Integrated the router instance into the useAlbumsRefresher composable and updated its usage in the Albums view. [1] [2]

Backend Updates:

  • Added a /login route to the backend (routes/web_v2.php) to serve the new login page.

@ildyria ildyria requested a review from a team as a code owner May 21, 2025 11:34
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label May 21, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (8698318) to head (048bc98).
Report is 1 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria added the alpha-ready Branch is available in alpha label May 21, 2025
@ildyria ildyria merged commit c2b4515 into master May 25, 2025
35 checks passed
@ildyria ildyria deleted the login-page branch May 25, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alpha-ready Branch is available in alpha Review: easy Easy review expected: probably just need a quick to go through.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants