Skip to content

Drop legacy id#3375

Merged
ildyria merged 4 commits intomasterfrom
drop-legacy-id
May 27, 2025
Merged

Drop legacy id#3375
ildyria merged 4 commits intomasterfrom
drop-legacy-id

Conversation

@ildyria
Copy link
Copy Markdown
Member

@ildyria ildyria commented May 27, 2025

Cleaning up dead code.

@ildyria ildyria requested a review from a team as a code owner May 27, 2025 09:44
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label May 27, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.01%. Comparing base (de63f58) to head (0deac35).
Report is 4 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria merged commit ac67199 into master May 27, 2025
35 checks passed
@ildyria ildyria deleted the drop-legacy-id branch May 27, 2025 23:49
@haivala
Copy link
Copy Markdown

haivala commented May 28, 2025

I have links in my other service to galleries. Is there a way to update the current https://lychee/#16230578300845 links to the new format?

@ildyria
Copy link
Copy Markdown
Member Author

ildyria commented May 28, 2025

I have links in my other service to galleries. Is there a way to update the current lychee#16230578300845 links to the new format?

Unfortunately not without manual work while staying temporarily on version before 6.6.0.
On 6.6.0 we dropped all the legacy API and in that one was contained also the legacy id redirection.

Note that the older link of style lychee#<24-alpha-num-chars> are still converted by the front-end into lychee/gallery/<24-alpha-num-chars>: https://github.com/LycheeOrg/Lychee/blob/master/resources/views/vueapp.blade.php#L14

However older links like lychee#<0-9 digits style> no longer works already since version 6.6.0. It is frustrating and we really try to keep braking changes at minimum, but unfortunately on that one, we need to bite the bullet. :|
Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review: easy Easy review expected: probably just need a quick to go through.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants