Conversation
ildyria
added
the
Review: easy
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix search route issue + add children constraint + add " " a la Google search
This pull request introduces enhancements to the album search functionality and refines the handling of search terms and navigation in the gallery panels. The most important changes include adding support for scoped album searches, improving the parsing of search terms, and adjusting navigation routes.
Enhancements to album search functionality:
app/Actions/Search/AlbumSearch.php: UpdatedqueryAlbumsto accept an optionalAlbumparameter, enabling searches to be scoped to a specific album and its descendants. The query now applies constraints based on the album's_lftand_rgtvalues.app/Http/Controllers/Gallery/SearchController.php: Modified the call toqueryAlbumsto pass theAlbumparameter, ensuring the scoped search functionality is utilized.Improvements to search term parsing:
app/Http/Requests/Search/GetSearchRequest.php: Enhanced the parsing of search terms by introducing a regex-based approach that handles quoted strings as single terms while splitting unquoted text by spaces. This ensures better handling of complex search queries.Adjustments to navigation routes:
resources/js/views/gallery-panels/Search.vue: Updated navigation routes to consistently use thesearchroute instead ofsearch-with-albumwhen navigating back or handling the "Escape" key, simplifying the routing logic. [1] [2]