Add Persian language and fix LTR and RTL display#3419
Merged
Conversation
ildyria
added
the
Review: hard
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Co-authored-by: Foad Alavi <foad.alavi@nl.abnamro.com> Co-authored-by: Foad <foadalavi@gmail.com>
ildyria
changed the title
d7415
approved these changes
Jun 23, 2025
Comment on lines
+7
to
+12
| <span class="text-warning-700" | ||
| ><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("dialogs.transfer.lost_access_warning") }}</span | ||
| ><br /> | ||
| <span class="text-warning-700"><i class="pi pi-exclamation-triangle mr-2" />{{ $t("dialogs.transfer.warning") }}</span> | ||
| <span class="text-warning-700" | ||
| ><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("dialogs.transfer.warning") }}</span | ||
| > |
Contributor
There was a problem hiding this comment.
It was like this already, but this seems an odd place to split lines?
Member
Author
There was a problem hiding this comment.
yeah the auto format is forcing it. :(
I will double check.
Comment on lines
+6
to
+8
| <span class="text-warning-700" | ||
| ><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("dialogs.delete_album.warning") }}</span | ||
| > |
Comment on lines
+11
to
+13
| <span class="text-warning-700" | ||
| ><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("sharing.propagate_warning") }}</span | ||
| > |
Comment on lines
+7
to
+9
| <span class="text-warning-700" | ||
| ><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("dialogs.delete_album.warning") }}</span | ||
| > |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new language files for Persian (
fa) translations, enhancing localization support for various pages and features in the application. Additionally, a minor adjustment was made to an Arabic (ar) language file. The most important changes include adding translations for new pages, improving user interface elements, and fixing specific text alignment issues.Persian (
fa) Localization Additionstemplates added.
Arabic (
ar) Language File Adjustment:lang/ar/settings.php: Fixed a text alignment issue by changing the icon's margin direction frommr-2toml-2for better visual consistency.