Conversation
ildyria
added
the
Review: easy
JasonMillward
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the
UserFactoryclass by removing custom methods for generating unique names and emails and replacing them with the built-in Faker library's functionality. This change improves code readability and reduces complexity.Simplifications in
UserFactory:database/factories/UserFactory.php: Replaced theget_name()method withfaker->unique()->name()for generating unique usernames.database/factories/UserFactory.php: Replaced theget_email()method withfaker->unique()->email()for generating unique email addresses.database/factories/UserFactory.php: Removed the customget_name()andget_email()methods entirely, along with their associated logic for avoiding collisions.