Merged
Conversation
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
f5dc9d0 to
3756aa0
Compare
3756aa0 to
6dde592
Compare
sancsin
approved these changes
Jun 28, 2025
Member
Author
6dde592 to
2bbce04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to user group management and access permission handling. Key changes include the addition of constants for user group attributes, modifications to access permission queries to incorporate user group-based permissions, and updates to ensure proper verification of feature availability.
User Group Management Enhancements:
app/Constants/UsersUserGroupsConstants.php: Added a new constants class to define table names and attribute identifiers for user groups, improving maintainability and consistency.Access Permission Handling:
app/Policies/AlbumQueryPolicy.php: Updated thegetComputedAccessPermissionSubQuerymethod to include user group-based permissions in access queries. This ensures permissions can be evaluated based on both individual users and their associated user groups.Feature Verification Updates:
app/Http/Resources/Rights/SettingsRightsResource.php: Updated thecan_acess_user_groupsproperty in the constructor to use theVerify::checkmethod for verifying feature availability, ensuring robust validation.Namespace Additions:
app/Policies/AlbumQueryPolicy.php: AddedUsersUserGroupsConstantsto the namespace for consistent referencing of user group-related constants.Dependency Inclusion:
app/Http/Resources/Rights/SettingsRightsResource.php: AddedLycheeVerify\Verifyto imports to support feature verification logic.