Skip to content

Fix 500 on search#3441

Merged
ildyria merged 2 commits intomasterfrom
fix500-search
Jun 13, 2025
Merged

Fix 500 on search#3441
ildyria merged 2 commits intomasterfrom
fix500-search

Conversation

@ildyria
Copy link
Copy Markdown
Member

@ildyria ildyria commented Jun 12, 2025

Consequence of the album requirement on PhotoResource...

Backend Changes:

  • Enhanced ResultsResource to support album context:

    • Updated the fromData method in ResultsResource to accept an optional AbstractAlbum parameter. This allows the resource to include album-specific context when constructing photo resources.
    • Modified the SearchController to pass the album parameter to ResultsResource when constructing the response.
  • Dependency inclusion:

    • Added the AbstractAlbum contract import in ResultsResource to support the new parameter.

Frontend Changes:

  • Improved global search handling in MetricsService:
    • Updated the logic to treat "all" as a valid album ID for global search mode in two methods (photo and favourite). This ensures consistent behavior when no specific album is targeted. [1] [2]

@ildyria ildyria requested a review from a team as a code owner June 12, 2025 21:29
@ildyria ildyria added Review: easy Easy review expected: probably just need a quick to go through. High Priority High priority issues labels Jun 12, 2025
@ildyria ildyria mentioned this pull request Jun 12, 2025
Comment thread resources/js/services/metrics-service.ts Outdated
Comment thread resources/js/services/metrics-service.ts Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.66%. Comparing base (be1ecf0) to head (60af847).
Report is 4 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria merged commit 58ba235 into master Jun 13, 2025
35 checks passed
@ildyria ildyria deleted the fix500-search branch June 13, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority High priority issues Review: easy Easy review expected: probably just need a quick to go through.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants