Skip to content

Check Imagick version 7 in diagnostics.#3455

Merged
ildyria merged 2 commits intomasterfrom
support-imagick-7
Jun 14, 2025
Merged

Check Imagick version 7 in diagnostics.#3455
ildyria merged 2 commits intomasterfrom
support-imagick-7

Conversation

@ildyria
Copy link
Copy Markdown
Member

@ildyria ildyria commented Jun 14, 2025

No description provided.

@ildyria ildyria requested a review from a team as a code owner June 14, 2025 17:25
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jun 14, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 14, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.64%. Comparing base (ac589a9) to head (fc50d97).
Report is 2 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +26 to +27
'/etc/ImageMagick-6/policy.xml',
'/etc/ImageMagick-7/policy.xml',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth swapping these so that it checks 7 first? Not sure how likely/possible it is to install both, but I wouldn't be surprised if old, unused config files were left behind.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hummm good point.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: fc50d97

@ildyria ildyria merged commit c4eccad into master Jun 14, 2025
35 checks passed
@ildyria ildyria deleted the support-imagick-7 branch June 14, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review: easy Easy review expected: probably just need a quick to go through.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants