Skip to content

Remove user constraint on decoding Limiter#4292

Merged
ildyria merged 1 commit intomasterfrom
fix-undefined-properties
Apr 14, 2026
Merged

Remove user constraint on decoding Limiter#4292
ildyria merged 1 commit intomasterfrom
fix-undefined-properties

Conversation

@ildyria
Copy link
Copy Markdown
Member

@ildyria ildyria commented Apr 14, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Updated geo-queue rate limiting to apply uniformly using default throttling behavior instead of per-request differentiation.

@ildyria ildyria requested a review from a team as a code owner April 14, 2026 12:59
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 72f03713-bbe9-4f8a-9eeb-7ef996ced68a

📥 Commits

Reviewing files that changed from the base of the PR and between 896f517 and e5caf77.

📒 Files selected for processing (1)
  • app/Providers/AppServiceProvider.php

📝 Walkthrough

Walkthrough

The rate limiter configuration for the geo-queue in the application's service provider was updated to remove per-user scoping. The limit now applies globally instead of being differentiated by individual user identifiers, reducing the granularity of rate limiting for this queue.

Changes

Cohort / File(s) Summary
Rate Limiter Configuration
app/Providers/AppServiceProvider.php
Removed .by($job->user->id) chaining from the geo-queue rate limiter definition, changing throttling from per-user to global application-level limits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 No more users kept apart,
The geo-queue takes a simpler start,
One limit rules them all today,
Scoping melts like morning's gray,
Per-user chains? Now cast away!

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.20%. Comparing base (896f517) to head (e5caf77).
⚠️ Report is 3 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria merged commit 5c67a33 into master Apr 14, 2026
45 checks passed
@ildyria ildyria deleted the fix-undefined-properties branch April 14, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant