Skip to content

feat: add is_embed_enabled config to gate embed endpoints and UI#4314

Closed
Copilot wants to merge 2 commits intomasterfrom
copilot/add-config-setting-is-embed-enabled
Closed

feat: add is_embed_enabled config to gate embed endpoints and UI#4314
Copilot wants to merge 2 commits intomasterfrom
copilot/add-config-setting-is-embed-enabled

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 22, 2026

Adds a new config-category boolean setting is_embed_enabled (default: 1) that acts as a master switch for the embed feature — disabling API endpoints at the HTTP layer and hiding all embed UI entry points.

Backend

  • Migration: inserts is_embed_enabled BOOL into the configs table (category config, default 1)
  • InitConfig: exposes the value to the frontend via the init endpoint
  • EmbedController: both getAlbum and getPublicStream throw a generic 404 when the setting is off — no feature-disclosure in the response

Frontend

  • lychee.d.ts: adds is_embed_enabled: boolean to InitConfig type
  • LycheeState: stores and hydrates the value from the init response
  • AlbumHero.vue: isEmbeddable computed returns false when disabled, hiding the embed button
  • leftMenu.ts: "Embed Stream" menu item gated on is_embed_enabled

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.50%. Comparing base (3d0cfac) to head (7482c27).
⚠️ Report is 1 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria closed this Apr 23, 2026
@ildyria ildyria deleted the copilot/add-config-setting-is-embed-enabled branch April 23, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants