fix(story-06): deterministic iOS sim + platform-split keyboard-guard smoke step (#387) (#490)

Two device-CI-surfaced fixes on the final acceptance run (28783702105):

- iOS 'open' failed 'No booted ios device found (or multiple booted)' on a
  DerivedData cache-HIT run (the build step, which had incidentally
  normalized sim state, was skipped). Shut down all sims then boot exactly
  one in pre-boot — device_snapshot open refuses on >1 booted.

- Android reached row 80 (union-bbox scroll works!) then failed at
  'fixture_bottom_button missing from the post-fill snapshot': the fill
  raised the soft keyboard and, with adjustNothing, the bottom bar is
  occluded — and Android UiAutomator DROPS occluded views (195 nodes incl.
  the full keyboard, but no bottom bar). iOS XCUITest keeps them. So the
  keyboard-guard step is now platform-split: iOS re-snapshots for a fresh
  occluded ref and asserts the refusal contract; Android presses the
  pre-fill ref (cached coords now under the keyboard) WITHOUT
  re-snapshotting (which would invalidate it — ref-map only updates on
  explicit snapshot commands) and asserts the dismiss contract.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Author: Lykhoyda

.changeset/story-06-smoke-kbguard-device-resolution.md

@@ -0,0 +1,5 @@
+---
+'rn-dev-agent-plugin': patch
+---
+
+Nightly device-smoke fixes: (1) the iOS lane now shuts down any pre-booted simulators before booting exactly one, so `device_snapshot open` (which refuses on >1 booted iOS device) resolves deterministically. (2) The keyboard-guard step is platform-split: Android UiAutomator drops occluded views, so the occluded bottom button is absent from a post-fill snapshot — the driver now presses the pre-fill ref (its cached coords are under the keyboard) without re-snapshotting, exercising the Android dismiss contract; iOS keeps its re-snapshot + refusal-contract path (XCUITest reports occluded elements).

.github/workflows/nightly-device-smoke.yml

@@ -59,7 +59,11 @@ jobs:
             UDID="$(xcrun simctl list devices available --json | jq -r '[.devices[] | .[] | select(.name | startswith("iPhone"))][0].udid // empty')"
           fi
           [ -n "$UDID" ]
-          xcrun simctl boot "$UDID" || true
+          # Shut down any pre-booted simulators first: device_snapshot open
+          # resolves "the booted iOS device" and refuses on >1 booted. The
+          # macos image can auto-boot a default sim, so boot EXACTLY one.
+          xcrun simctl shutdown all || true
+          xcrun simctl boot "$UDID"
           xcrun simctl bootstatus "$UDID" -b
           echo "SMOKE_UDID=$UDID" >> "$GITHUB_ENV"
       - name: Build runner (cache miss only)

scripts/cdp-bridge/test/smoke/device-smoke.ts

@@ -281,6 +281,12 @@ test(`Phase B golden set (${PLATFORM})`, { timeout: 900_000 }, async () => {
     }
 
     snap = record('snapshot-3', await callTool(s, 'device_snapshot', { action: 'snapshot' }));
+    // Capture the bottom button ref NOW, while the keyboard is down and the
+    // button is visible — needed for the keyboard-guard step below, because on
+    // Android the button disappears from the tree once the keyboard occludes it
+    // (see the platform branch there).
+    const preFillBottomRef = refFor(snap.envelope, 'fixture_bottom_button');
+    assert.ok(preFillBottomRef, 'fixture_bottom_button missing from the pre-fill snapshot');
     const fill = record(
       'fill',
       await callTool(s, 'device_fill', {
@@ -290,44 +296,56 @@ test(`Phase B golden set (${PLATFORM})`, { timeout: 900_000 }, async () => {
     );
     assert.equal(fill.envelope?.ok, true, `fill failed: ${fill.text.slice(0, 500)}`);
 
-    // Keyboard-guard scenario (#370 contract): the fill above left the
-    // keyboard up; the bottom bar sits under it by fixture design.
-    // FRESH snapshot first — @eN refs are positional snapshot tokens, and the
-    // keyboard's arrival rewrote the tree, so a pre-fill ref would silently
-    // bind to a different element at the same index (device-proven: it tapped
-    // a list row dead-center instead of the bottom button).
-    snap = record(
-      'snapshot-post-fill',
-      await callTool(s, 'device_snapshot', { action: 'snapshot' }),
-    );
-    const bottomRef = refFor(snap.envelope, 'fixture_bottom_button');
-    assert.ok(bottomRef, 'fixture_bottom_button missing from the post-fill snapshot');
-    const kb = record('keyboard-guard', await callTool(s, 'device_press', { ref: bottomRef }));
-    const guard = kb.envelope?.meta?.keyboardGuard;
-    if (PLATFORM === 'android') {
-      // no_keyboard = environment problem (soft IME never appeared), not a
-      // contract result — fail with the fix, don't let it masquerade.
-      assert.notEqual(
-        guard,
-        'no_keyboard',
-        'Soft keyboard never appeared — the emulator needs `adb shell settings put secure show_ime_with_hard_keyboard 1` (the nightly workflow sets it)',
+    // Keyboard-guard scenario (#370 contract): the fill left the keyboard up and
+    // the bottom bar is occluded by it (fixture uses adjustNothing / ignoresSafeArea).
+    // The platforms diverge in TWO ways here:
+    //   - iOS XCUITest still reports the occluded button, so re-snapshot for a
+    //     fresh ref and press it → the guard must REFUSE (KEYBOARD_OCCLUDED /
+    //     dismiss_failed): XCTest swipeDown on a QWERTY keyboard corrupts fields.
+    //   - Android UiAutomator DROPS occluded views, so the button is gone from a
+    //     post-fill snapshot. Press the pre-fill ref instead (its cached coords
+    //     are under the keyboard now) WITHOUT re-snapshotting — a snapshot would
+    //     repopulate the ref-map and invalidate it. The guard must DISMISS.
+    let kb: ToolReply;
+    if (PLATFORM === 'ios') {
+      snap = record(
+        'snapshot-post-fill',
+        await callTool(s, 'device_snapshot', { action: 'snapshot' }),
       );
-      assert.equal(kb.envelope?.ok, true, `keyboard-guard press failed: ${kb.text.slice(0, 500)}`);
-      assert.equal(guard, 'dismissed', 'Android must dismiss the keyboard first');
-    } else {
+      const bottomRef = refFor(snap.envelope, 'fixture_bottom_button');
+      assert.ok(
+        bottomRef,
+        'iOS: fixture_bottom_button should remain in the post-fill snapshot (XCUITest reports occluded elements)',
+      );
+      kb = record('keyboard-guard', await callTool(s, 'device_press', { ref: bottomRef }));
       assert.notEqual(
         kb.envelope?.ok,
         true,
-        `iOS keyboard-guard scenario invalid: the tap went through (keyboardGuard=${guard}). ` +
+        `iOS keyboard-guard scenario invalid: the tap went through (keyboardGuard=${kb.envelope?.meta?.keyboardGuard}). ` +
           'The software keyboard likely never appeared on this headless simulator — environment problem, not a contract pass.',
       );
-      const body = kb.text;
-      assert.match(body, /KEYBOARD_OCCLUDED/, `expected KEYBOARD_OCCLUDED: ${body.slice(0, 500)}`);
       assert.match(
-        body,
+        kb.text,
+        /KEYBOARD_OCCLUDED/,
+        `expected KEYBOARD_OCCLUDED: ${kb.text.slice(0, 500)}`,
+      );
+      assert.match(
+        kb.text,
         /dismiss_failed/,
-        `expected keyboardGuard=dismiss_failed: ${body.slice(0, 500)}`,
+        `expected keyboardGuard=dismiss_failed: ${kb.text.slice(0, 500)}`,
       );
+    } else {
+      kb = record('keyboard-guard', await callTool(s, 'device_press', { ref: preFillBottomRef }));
+      const guard = kb.envelope?.meta?.keyboardGuard;
+      // no_keyboard = the soft IME never appeared (environment problem), not a
+      // contract result — fail with the fix rather than let it masquerade.
+      assert.notEqual(
+        guard,
+        'no_keyboard',
+        'Soft keyboard never appeared — the emulator needs `adb shell settings put secure show_ime_with_hard_keyboard 1` (the nightly workflow sets it)',
+      );
+      assert.equal(kb.envelope?.ok, true, `keyboard-guard press failed: ${kb.text.slice(0, 500)}`);
+      assert.equal(guard, 'dismissed', 'Android must dismiss the keyboard first');
     }
 
     const neg = record(