Skip to content

Commit 80c225e

Browse files
Lykhoydaclaude
andauthored
fix(ci): run nested test dirs in CI (#340) (#355)
CI ran `node --test 'test/unit/*.test.js'` (top-level glob only) while the canonical `npm test` runs both `test/unit/*.test.js` AND `test/unit/**/*.test.js`. Six nested files in test/unit/runners/ and test/unit/tools/ (runner clients, external-runner-detect, find/scrollintoview orchestration) — 22 tests — were never executed in CI, so a regression in any of them could reach main undetected. Align the CI unit + integration globs with `npm test`. Verified locally: top-level-only glob = 2341 tests, aligned glob = 2363 tests, all passing. The integration glob gets the same nested coverage preemptively (no nested integration files exist yet). Closes #340 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 4db8831 commit 80c225e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@ jobs:
3838
working-directory: scripts/cdp-bridge
3939

4040
- name: Unit tests
41-
run: node --test 'test/unit/*.test.js'
41+
run: node --test 'test/unit/*.test.js' 'test/unit/**/*.test.js'
4242
working-directory: scripts/cdp-bridge
4343

4444
- name: Integration tests
45-
run: node --test 'test/integration/*.test.js'
45+
run: node --test 'test/integration/*.test.js' 'test/integration/**/*.test.js'
4646
working-directory: scripts/cdp-bridge
4747

4848
# Runs at repo root (no working-directory) — guards the changeset CI gate.

0 commit comments

Comments
 (0)