Skip to content

Commit df5c76e

Browse files
Lykhoydaclaude
andauthored
fix(story-06): full-amplitude scroll in the smoke golden set so Android reaches row 80 (#387) (#484)
The first green-path acceptance run (28782056292) passed iOS end-to-end and ran all 30 Android scrolls with ZERO RUNNER_TIMEOUT — confirming the local drag-latency that motivated Android's amount-0.5 guard was pure host degradation, not a CI constraint. At SWIPE_FRACTION 0.4, amount 0.5 travels only ~0.2*height/scroll (~3 rows), so 30 scrolls fell ~5 rows short of row 80. Use amount 1 on both platforms (~0.4*height/scroll). Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent f58c85d commit df5c76e

2 files changed

Lines changed: 12 additions & 7 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'rn-dev-agent-plugin': patch
3+
---
4+
5+
Nightly device-smoke Android lane: scroll the golden-set list at full amplitude (amount 1) so row 80 is reached within the 30-scroll budget. The earlier amount-0.5 guard (added for a local emulator's drag latency) fell ~5 rows short on CI, where all 30 drags run with zero RUNNER_TIMEOUT — the shorter drag bought nothing.

scripts/cdp-bridge/test/smoke/device-smoke.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -222,13 +222,13 @@ test(`Phase B golden set (${PLATFORM})`, { timeout: 900_000 }, async () => {
222222

223223
// device_scrollintoview does exactly ONE blind swipe when the target is
224224
// absent from the snapshot (device-interact.ts:1383) — row 80 is several
225-
// screens away (~10 rows visible per screen), so scroll until the row is
226-
// IN a snapshot, then let the verb finish on its supported path.
227-
// Android: a full-amplitude fling (amount 1) on a loaded emulator can make
228-
// the UiAutomator drag gesture exceed the runner's 10s budget; a shorter
229-
// drag completes fast and still advances several rows. iOS List needs the
230-
// fuller gesture to cover ground within the iteration budget.
231-
const scrollAmount = PLATFORM === 'android' ? 0.5 : 1;
225+
// screens away, so scroll until the row is IN a snapshot, then let the verb
226+
// finish on its supported path. Full amplitude (amount 1) on both platforms:
227+
// at SWIPE_FRACTION 0.4, amount 1 travels ~0.4*height per scroll (~5+ rows),
228+
// reaching row 80 well inside the 30-iteration budget. (A brief amount-0.5
229+
// Android trial fell ~5 rows short at 30 scrolls; the CI emulator runs all
230+
// 30 drags with zero RUNNER_TIMEOUT, so the shorter drag bought nothing.)
231+
const scrollAmount = 1;
232232
let rowVisible = false;
233233
for (let i = 0; i < 30 && !rowVisible; i++) {
234234
const scroll = record(

0 commit comments

Comments
 (0)